Christoph Egger
2008-Feb-18 12:32 UTC
[Xen-devel] [PATCH] Allow 32bit PAE guests to change their L3 entries
Hi! adjust_guest_l3e() adds (_PAGE_USER|_PAGE_RW) to the entry, and then get_page_from_l3e() checks that _PAGE_USER or _PAGE_RW are not present for PAE guests. get_page_from_l3e() will always fail at this point for PAE guests. Attached patch fixes this. This bug has been uncovered with NetBSD 32bit PAE guests. Patch from Manuel Bouyer <bouyer@netbsd.org> for xen-3.1-testing, ported to xen-unstable by me. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> Keir: Please apply this patch also to xen-3.2-testing and xen-3.1-testing. -- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2008-Feb-18 13:44 UTC
Re: [Xen-devel] [PATCH] Allow 32bit PAE guests to change their L3 entries
On 18/2/08 12:32, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> adjust_guest_l3e() adds (_PAGE_USER|_PAGE_RW) to the entry, and then > get_page_from_l3e() checks that _PAGE_USER or _PAGE_RW are not present > for PAE guests. get_page_from_l3e() will always fail at this point > for PAE guests. > > Attached patch fixes this. This bug has been uncovered with NetBSD 32bit PAE > guests.It breaks the fast update path, and also all mod_lN_entry() functions should probably be reorganised for consistency. I''ll make these changes and apply it. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2008-Feb-18 13:57 UTC
Re: [Xen-devel] [PATCH] Allow 32bit PAE guests to change their L3 entries
On Monday 18 February 2008 14:44:32 Keir Fraser wrote:> On 18/2/08 12:32, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > adjust_guest_l3e() adds (_PAGE_USER|_PAGE_RW) to the entry, and then > > get_page_from_l3e() checks that _PAGE_USER or _PAGE_RW are not present > > for PAE guests. get_page_from_l3e() will always fail at this point > > for PAE guests. > > > > Attached patch fixes this. This bug has been uncovered with NetBSD 32bit > > PAE guests. > > It breaks the fast update path, and also all mod_lN_entry() functions > should probably be reorganised for consistency. I''ll make these changes and > apply it.Thank you very much. But shouldn''t have c/s 17061 gone into xen-staging first and then into xen-stable ? Christoph -- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2008-Feb-18 14:35 UTC
Re: [Xen-devel] [PATCH] Allow 32bit PAE guests to change their L3 entries
On 18/2/08 13:57, "Christoph Egger" <Christoph.Egger@amd.com> wrote:>> It breaks the fast update path, and also all mod_lN_entry() functions >> should probably be reorganised for consistency. I''ll make these changes and >> apply it. > > Thank you very much. But shouldn''t have c/s 17061 gone into xen-staging first > and then into xen-stable ?It''s in both. Also now in 3.2 and 3.1 staging trees. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2008-Feb-18 14:41 UTC
Re: [Xen-devel] [PATCH] Allow 32bit PAE guests to change their L3 entries
On Monday 18 February 2008 15:35:28 Keir Fraser wrote:> On 18/2/08 13:57, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > >> It breaks the fast update path, and also all mod_lN_entry() functions > >> should probably be reorganised for consistency. I''ll make these changes > >> and apply it. > > > > Thank you very much. But shouldn''t have c/s 17061 gone into xen-staging > > first and then into xen-unstable ? > > It''s in both. Also now in 3.2 and 3.1 staging trees.Thanks. I just was surprised seeing the patch in xen-unstable before in xen-staging. Maybe your automated regression system had a kind of a "race" window :) Christoph -- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2008-Feb-18 15:03 UTC
Re: [Xen-devel] [PATCH] Allow 32bit PAE guests to change their L3 entries
On 18/2/08 14:41, "Christoph Egger" <Christoph.Egger@amd.com> wrote:>>> Thank you very much. But shouldn''t have c/s 17061 gone into xen-staging >>> first and then into xen-unstable ? >> >> It''s in both. Also now in 3.2 and 3.1 staging trees. > > Thanks. I just was surprised seeing the patch in xen-unstable before in > xen-staging. Maybe your automated regression system had a kind of a "race" > window :)I pushed it through manually as the test harness has failed (apparently) spuriously a couple of times in a row. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel