This patch provides the netback plug-in module (sfc_netback) to accelerate network access on Solarflare NICs. Signed-off-by: Kieran Mansley <kmansley@solarflare.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Hi, Looks like this patch (linux-2.6.18-xen.hg 423:af0d925ba938) is causing a build failure. ==============================In file included from drivers/xen/sfc_netback/accel_solarflare.c:36: drivers/xen/sfc_netback/ci/efrm/nic_table.h:41:32: error: ci/efhw/efhw_types.h: No such file or directory drivers/xen/sfc_netback/ci/efrm/nic_table.h:42:28: error: ci/efrm/sysdep.h: No such file or directory In file included from drivers/xen/sfc_netback/accel_solarflare.c:36: drivers/xen/sfc_netback/ci/efrm/nic_table.h:54: error: ''EFHW_MAX_NR_DEVS'' undeclared here (not in a function) In file included from drivers/xen/sfc_netback/accel_solarflare.c:37: drivers/xen/sfc_netback/ci/efhw/public.h:42:28: error: ci/efhw/common.h: No such file or directory In file included from drivers/xen/sfc_netback/accel_solarflare.c:37: drivers/xen/sfc_netback/ci/efhw/public.h: In function ''efhw_nic_have_functional_units'': drivers/xen/sfc_netback/ci/efhw/public.h:49: error: dereferencing pointer to incomplete type cc1: warnings being treated as errors drivers/xen/sfc_netback/ci/efhw/public.h: In function ''efhw_nic_have_hw'': drivers/xen/sfc_netback/ci/efhw/public.h:55: warning: implicit declaration of function ''EFHW_KVA'' drivers/xen/sfc_netback/ci/efhw/public.h: At top level: drivers/xen/sfc_netback/ci/efhw/public.h:68: warning: ''struct eventq_resource_hardware'' declared inside parameter list drivers/xen/sfc_netback/ci/efhw/public.h:68: warning: its scope is only this definition or declaration, which is probably not what you want drivers/xen/sfc_netback/accel_solarflare.c: In function ''efx_device_to_efab_nic_index'': drivers/xen/sfc_netback/accel_solarflare.c:183: error: dereferencing pointer to incomplete type drivers/xen/sfc_netback/accel_solarflare.c:187: error: dereferencing pointer to incomplete type make[3]: *** [drivers/xen/sfc_netback/accel_solarflare.o] Error 1 make[2]: *** [drivers/xen/sfc_netback] Error 2 make[1]: *** [drivers/xen] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [drivers] Error 2 + exit 1 error: Bad exit status from /var/tmp/rpm-tmp.77273 (%build) ============================== Did you mean to add -Idrivers/net/sfc/sfc_resource or -Idrivers/xen/sfc_netback to drivers/xen/sfc_netback/Makefile? Thanks kurt -- _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Kieran Mansley
2008-Feb-19 09:25 UTC
Re: [Xen-devel] [Patch 4/4] Accelerated network drivers
On Mon, 2008-02-18 at 14:37 -0800, Kurt Hackel wrote:> Hi, > > Looks like this patch (linux-2.6.18-xen.hg 423:af0d925ba938) is > causing a build failure. > > Did you mean to add -Idrivers/net/sfc/sfc_resource or > -Idrivers/xen/sfc_netback to drivers/xen/sfc_netback/Makefile? >>From your errors it would certainly look like adding -Idrivers/xen/sfc_netback would fix it. What I don''t yet understand is why I''ve never seen this problem. I''ll investigate and sort out a patch. Kieran _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Kieran Mansley
2008-Feb-19 10:37 UTC
Re: [Xen-devel] [Patch 4/4] Accelerated network drivers
On Tue, 2008-02-19 at 09:25 +0000, Kieran Mansley wrote:> On Mon, 2008-02-18 at 14:37 -0800, Kurt Hackel wrote: > > Hi, > > > > Looks like this patch (linux-2.6.18-xen.hg 423:af0d925ba938) is > > causing a build failure. > > > > Did you mean to add -Idrivers/net/sfc/sfc_resource or > > -Idrivers/xen/sfc_netback to drivers/xen/sfc_netback/Makefile? > > > > >From your errors it would certainly look like adding - > Idrivers/xen/sfc_netback would fix it. What I don''t yet understand is > why I''ve never seen this problem. I''ll investigate and sort out a > patch.I''m still not sure why I''ve not seen this failure: a clean checkout and build has no problems for me, but the change should be harmless so I''ve attached a patch that should solve your problem. Signed-off-by Kieran Mansley <kmansley@solarflare.com> Thanks Kieran Add -I. to sfc module builds diff -r 9dea529497fe drivers/net/sfc/sfc_resource/Makefile --- a/drivers/net/sfc/sfc_resource/Makefile +++ b/drivers/net/sfc/sfc_resource/Makefile @@ -3,7 +3,7 @@ EXTRA_CFLAGS += -D__CI_HARDWARE_CONFIG_F EXTRA_CFLAGS += -D__CI_HARDWARE_CONFIG_FALCON__ EXTRA_CFLAGS += -D__ci_driver__ EXTRA_CFLAGS += -Werror -EXTRA_CFLAGS += -Idrivers/net/sfc +EXTRA_CFLAGS += -Idrivers/net/sfc -Idrivers/net/sfc/sfc_resource sfc_resource-objs := resource_driver.o iopage.o efx_vi_shm.o \ driverlink_new.o kernel_proc.o kfifo.o \ diff -r 9dea529497fe drivers/xen/sfc_netback/Makefile --- a/drivers/xen/sfc_netback/Makefile +++ b/drivers/xen/sfc_netback/Makefile @@ -1,4 +1,4 @@ EXTRA_CFLAGS += -Idrivers/xen/sfc_netuti -EXTRA_CFLAGS += -Idrivers/xen/sfc_netutil -Idrivers/xen/netback -Idrivers/net/sfc +EXTRA_CFLAGS += -Idrivers/xen/sfc_netback -Idrivers/xen/sfc_netutil -Idrivers/xen/netback -Idrivers/net/sfc EXTRA_CFLAGS += -D__ci_driver__ EXTRA_CFLAGS += -DEFX_USE_KCOMPAT EXTRA_CFLAGS += -Werror diff -r 9dea529497fe drivers/xen/sfc_netfront/Makefile --- a/drivers/xen/sfc_netfront/Makefile +++ b/drivers/xen/sfc_netfront/Makefile @@ -1,4 +1,4 @@ EXTRA_CFLAGS += -Idrivers/xen/sfc_netuti -EXTRA_CFLAGS += -Idrivers/xen/sfc_netutil -Idrivers/xen/netfront +EXTRA_CFLAGS += -Idrivers/xen/sfc_netfront -Idrivers/xen/sfc_netutil -Idrivers/xen/netfront EXTRA_CFLAGS += -D__ci_driver__ EXTRA_CFLAGS += -Werror diff -r 9dea529497fe drivers/xen/sfc_netutil/Makefile --- a/drivers/xen/sfc_netutil/Makefile +++ b/drivers/xen/sfc_netutil/Makefile @@ -1,3 +1,4 @@ EXTRA_CFLAGS += -Werror +EXTRA_CFLAGS += -Idrivers/xen/sfc_netutil EXTRA_CFLAGS += -Werror ifdef GGOV _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel