Alex Williamson
2008-Jan-27 15:11 UTC
[Xen-devel] [PATCH] Re: [Xen-staging] [xen-unstable] libxc: Remove duplicate zlib check.
On Sun, 2008-01-27 at 13:00 +0000, Xen staging patchbot-unstable wrote:> # HG changeset patch > # User Keir Fraser > # Date 1201438436 0 > # Node ID 7e5bae3586eef2350f0dbc77c081d46ba4d67b2b > # Parent 5d11d526a82052f796f2f414c273e95cc07db596 > libxc: Remove duplicate zlib check. > > It is already checked in tools/check/check_zlib. > > Signed-off-by: Bastian Blank > --- > tools/libxc/Makefile | 11 +---------- > 1 files changed, 1 insertion(+), 10 deletions(-) > > diff -r 5d11d526a820 -r 7e5bae3586ee tools/libxc/Makefile > --- a/tools/libxc/Makefile Sun Jan 27 12:53:35 2008 +0000 > +++ b/tools/libxc/Makefile Sun Jan 27 12:53:56 2008 +0000 > @@ -80,17 +80,8 @@ all: build > all: build > > .PHONY: build > -build: check-for-zlib > +build: $(LIB) > $(MAKE) $(LIB)This is killing tools/libxc/ia64/Makefile (ie. we''re not getting the links setup to be able to build). Perhaps this? Thanks, Alex Signed-off-by: Alex Williamson <alex.williamson@hp.com> diff -r f605f35bd6ba tools/libxc/Makefile --- a/tools/libxc/Makefile Sun Jan 27 13:03:10 2008 +0000 +++ b/tools/libxc/Makefile Sun Jan 27 08:10:38 2008 -0700 @@ -80,7 +80,7 @@ all: build all: build .PHONY: build -build: $(LIB) +build: $(MAKE) $(LIB) .PHONY: install _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Bastian Blank
2008-Jan-27 16:22 UTC
[Xen-devel] Re: [PATCH] Re: [Xen-staging] [xen-unstable] libxc: Remove duplicate zlib check.
On Sun, Jan 27, 2008 at 08:11:41AM -0700, Alex Williamson wrote:> > -build: check-for-zlib > > +build: $(LIB) > > $(MAKE) $(LIB)This is broken anyway.> This is killing tools/libxc/ia64/Makefile (ie. we''re not getting the > links setup to be able to build). Perhaps this? Thanks,Is that correct that the ia64 libxc build needs private headers? Bastian -- I object to intellect without discipline; I object to power without constructive purpose. -- Spock, "The Squire of Gothos", stardate 2124.5 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Alex Williamson
2008-Jan-27 16:59 UTC
[Xen-devel] Re: [PATCH] Re: [Xen-staging] [xen-unstable] libxc: Remove duplicate zlib check.
On Sun, 2008-01-27 at 17:22 +0100, Bastian Blank wrote:> On Sun, Jan 27, 2008 at 08:11:41AM -0700, Alex Williamson wrote: > > > -build: check-for-zlib > > > +build: $(LIB) > > > $(MAKE) $(LIB) > > This is broken anyway. > > > This is killing tools/libxc/ia64/Makefile (ie. we''re not getting the > > links setup to be able to build). Perhaps this? Thanks, > > Is that correct that the ia64 libxc build needs private headers?ia64 libxc shares a number of header files with xen for domain building. These get linked under libxc/ia64 and are included in the libxc build by adding -Iia64 to the include path. Alex -- Alex Williamson HP Open Source & Linux Org. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2008-Jan-27 17:03 UTC
[Xen-devel] Re: [PATCH] Re: [Xen-staging] [xen-unstable] libxc: Remove duplicate zlib check.
On 27/1/08 16:59, "Alex Williamson" <alex.williamson@hp.com> wrote:>> Is that correct that the ia64 libxc build needs private headers? > > ia64 libxc shares a number of header files with xen for domain > building. These get linked under libxc/ia64 and are included in the > libxc build by adding -Iia64 to the include path.I made an alternative fix in c/s 16916 which preserves the potential parallelism in building the actual libraries. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel