Bastian Blank
2008-Jan-22 13:26 UTC
[Xen-devel] [PATCH 1/6] makefiles - Add PREFIX definition
# HG changeset patch # User Bastian Blank <waldi@debian.org> # Date 1200745316 -3600 # Node ID c5c18c78ceaeb2a983fb917163f9a0b80be384fe # Parent 3f26758bcc020c741fdae010f969115064b577c2 Add PREFIX definition as base for all installed files. Signed-off-by: Bastian Blank <waldi@debian.org> diff -r 3f26758bcc02 -r c5c18c78ceae config/StdGNU.mk --- a/config/StdGNU.mk Fri Jan 18 22:27:51 2008 +0000 +++ b/config/StdGNU.mk Sat Jan 19 13:21:56 2008 +0100 @@ -17,6 +17,8 @@ INSTALL_DATA = $(INSTALL) -m0644 -p INSTALL_DATA = $(INSTALL) -m0644 -p INSTALL_PROG = $(INSTALL) -m0755 -p +PREFIX = /usr + LIB64DIR = lib64 SOCKET_LIBS diff -r 3f26758bcc02 -r c5c18c78ceae config/SunOS.mk --- a/config/SunOS.mk Fri Jan 18 22:27:51 2008 +0000 +++ b/config/SunOS.mk Sat Jan 19 13:21:56 2008 +0100 @@ -18,6 +18,8 @@ INSTALL_DATA = $(INSTALL) -m0644 -p INSTALL_DATA = $(INSTALL) -m0644 -p INSTALL_PROG = $(INSTALL) -m0755 -p +PREFIX = /usr + LIB64DIR = lib/amd64 SOCKET_LIBS = -lsocket _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2008-Jan-22 13:38 UTC
Re: [Xen-devel] [PATCH 1/6] makefiles - Add PREFIX definition
Short of this being configurable, I think this should be PREFIX ?= /usr in order to allow overriding it through the environment. Jan>>> Bastian Blank <bastian@waldi.eu.org> 22.01.08 14:26 >>># HG changeset patch # User Bastian Blank <waldi@debian.org> # Date 1200745316 -3600 # Node ID c5c18c78ceaeb2a983fb917163f9a0b80be384fe # Parent 3f26758bcc020c741fdae010f969115064b577c2 Add PREFIX definition as base for all installed files. Signed-off-by: Bastian Blank <waldi@debian.org> diff -r 3f26758bcc02 -r c5c18c78ceae config/StdGNU.mk --- a/config/StdGNU.mkFri Jan 18 22:27:51 2008 +0000 +++ b/config/StdGNU.mkSat Jan 19 13:21:56 2008 +0100 @@ -17,6 +17,8 @@ INSTALL_DATA = $(INSTALL) -m0644 -p INSTALL_DATA = $(INSTALL) -m0644 -p INSTALL_PROG = $(INSTALL) -m0755 -p +PREFIX = /usr + LIB64DIR = lib64 SOCKET_LIBS diff -r 3f26758bcc02 -r c5c18c78ceae config/SunOS.mk --- a/config/SunOS.mkFri Jan 18 22:27:51 2008 +0000 +++ b/config/SunOS.mkSat Jan 19 13:21:56 2008 +0100 @@ -18,6 +18,8 @@ INSTALL_DATA = $(INSTALL) -m0644 -p INSTALL_DATA = $(INSTALL) -m0644 -p INSTALL_PROG = $(INSTALL) -m0755 -p +PREFIX = /usr + LIB64DIR = lib/amd64 SOCKET_LIBS = -lsocket _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Bastian Blank
2008-Jan-22 13:57 UTC
Re: [Xen-devel] [PATCH 1/6] makefiles - Add PREFIX definition
On Tue, Jan 22, 2008 at 01:38:34PM +0000, Jan Beulich wrote:> Short of this being configurable, I think this should be > PREFIX ?= /usr > in order to allow overriding it through the environment.Hmm. Usualy you don''t use environment but makeflags to overwrite them. And both variants are overwritten by them. Bastian _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2008-Jan-22 14:17 UTC
Re: [Xen-devel] [PATCH 1/6] makefiles - Add PREFIX definition
Bastian Blank writes ("Re: [Xen-devel] [PATCH 1/6] makefiles - Add PREFIX
definition"):> On Tue, Jan 22, 2008 at 01:38:34PM +0000, Jan Beulich wrote:
> > Short of this being configurable, I think this should be
> > PREFIX ?= /usr
> > in order to allow overriding it through the environment.
>
> Hmm. Usualy you don''t use environment but makeflags to overwrite
them.
> And both variants are overwritten by them.
Yes, but people might like to do either. I think ?= is better practice.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel