Stephan Seitz
2007-Dec-31 12:13 UTC
[Xen-devel] [Fwd: [Xen-users] two serial port in HVM DomU patch]
Hi, attached is a patch posted at xen-users from Mishell Baranov for qemu-dm to support two serial lines. I think this is a feature that could be implemented in the unstable and testing branches. Regards, -- Stephan Seitz Senior System Administrator *netz-haut* e.K. multimediale kommunikation zweierweg 22 97074 würzburg fon: +49 931 2876247 fax: +49 931 2876248 web: www.netz-haut.de <http://www.netz-haut.de/> registriergericht: amtsgericht würzburg, hra 5054 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
James Harper
2007-Dec-31 12:32 UTC
RE: [Xen-devel] [Fwd: [Xen-users] two serial port in HVM DomU patch]
How much more work would it take to support an arbitrary number of serial ports?> -----Original Message----- > From: xen-devel-bounces@lists.xensource.com [mailto:xen-devel- > bounces@lists.xensource.com] On Behalf Of Stephan Seitz > Sent: Monday, 31 December 2007 23:13 > To: XEN Devel - listmembers > Subject: [Xen-devel] [Fwd: [Xen-users] two serial port in HVM DomU patch] > > Hi, > > attached is a patch posted at xen-users from Mishell Baranov for qemu-dm > to support two serial lines. > > I think this is a feature that could be implemented in the unstable and > testing branches. > > Regards, > > > -- > Stephan Seitz > Senior System Administrator > > *netz-haut* e.K. > multimediale kommunikation > > zweierweg 22 > 97074 würzburg > > fon: +49 931 2876247 > fax: +49 931 2876248 > > web: www.netz-haut.de <http://www.netz-haut.de/> > > registriergericht: amtsgericht würzburg, hra 5054_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Samuel Thibault
2007-Dec-31 12:41 UTC
Re: [Xen-devel] [Fwd: [Xen-users] two serial port in HVM DomU patch]
Hi, Stephan Seitz, le Mon 31 Dec 2007 13:13:06 +0100, a écrit :> @@ -5603,7 +5604,8 @@ > - { "serial", 1, QEMU_OPTION_serial }, > + { "seriala", 1, QEMU_OPTION_seriala }, > + { "serialb", 1, QEMU_OPTION_serialb },There is no real need to do this: qemu can handle several -serial options fine.> diff -ur xen-3.1-3.1.0/tools/python/xen/xm/create.py xen-3.1-3.1.0-my/tools/python/xen/xm/create.py > --- xen-3.1-3.1.0/tools/python/xen/xm/create.py 2007-05-18 20:45:21.000000000 +0600 > +++ xen-3.1-3.1.0-my/tools/python/xen/xm/create.py 2007-12-30 19:25:57.000000000 +0500 > -gopts.var(''serial'', val=''FILE'',And that could be a list of serial/pty/vc/... Samuel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Daniel P. Berrange
2008-Jan-06 22:42 UTC
Re: [Xen-devel] [Fwd: [Xen-users] two serial port in HVM DomU patch]
On Sun, Jan 06, 2008 at 10:43:23PM +0000, Keir Fraser wrote:> I''d advocate a dm_args domain config option, which would be a string of qemu > command-line arguments which would be dumbly passed straight through to > qemu-dm without any further processing by xend. > > Then you could just do ''dm_args = "serial=/dev/ttyS0 serial=/dev/ttyS1"'' and > not need any changes to qemu source code at all. And this would also let you > get at any other underlying features of qemu too. Much nicer.I think that''s a bad idea as any info in this generic ''dm_args'' is now lost to the formal API data model. eg If a management app wants to talk to XenD and determine how / if the serial port is configured, it now has to look at both the formally specified ''serial'' param, and also parse the command line args in ''dm_args''. Sure it means we have to write less code in XenD, but it means that all users talking to XenD have much more work todo. I don''t really see that as a net win. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2008-Jan-06 22:43 UTC
Re: [Xen-devel] [Fwd: [Xen-users] two serial port in HVM DomU patch]
I''d advocate a dm_args domain config option, which would be a string of qemu command-line arguments which would be dumbly passed straight through to qemu-dm without any further processing by xend. Then you could just do ''dm_args = "serial=/dev/ttyS0 serial=/dev/ttyS1"'' and not need any changes to qemu source code at all. And this would also let you get at any other underlying features of qemu too. Much nicer. This would certainly be a good thing post 3.2.0 and 3.1.3. -- Keir On 31/12/07 12:13, "Stephan Seitz" <s.seitz@netz-haut.de> wrote:> Hi, > > attached is a patch posted at xen-users from Mishell Baranov for qemu-dm to > support two serial lines. > > I think this is a feature that could be implemented in the unstable and > testing branches. > > Regards, >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Daniel P. Berrange
2008-Jan-06 22:45 UTC
Re: [Xen-devel] [Fwd: [Xen-users] two serial port in HVM DomU patch]
On Sun, Jan 06, 2008 at 10:46:20PM +0000, Keir Fraser wrote:> Ah, this is a nice way that continues to support the existing domain config > format. I''d still also like a dm_args config option too though! Really many > of the HVM-specific config options could be deprecated and moved over to a > single dm_args config field.No no no, please no. The current scheme is good because there are clear key,value pairs for each individual configuration option. A generic blob of dm_args will be a huge PITA to deal with, making a mockery of the attempt at clearly modelling guest config params in XenAPI, as well as the legacy config formats. It will also increase the divergance in the way HVM guests are configured vs paravirt guests if we start to shove all the HVM args into ''dm_args'' rather than representing them in a way which works well for both HVM and PV domains. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2008-Jan-06 22:46 UTC
Re: [Xen-devel] [Fwd: [Xen-users] two serial port in HVM DomU patch]
Ah, this is a nice way that continues to support the existing domain config format. I''d still also like a dm_args config option too though! Really many of the HVM-specific config options could be deprecated and moved over to a single dm_args config field. -- Keir On 31/12/07 12:41, "Samuel Thibault" <samuel.thibault@eu.citrix.com> wrote:> Hi, > > Stephan Seitz, le Mon 31 Dec 2007 13:13:06 +0100, a écrit : >> @@ -5603,7 +5604,8 @@ >> - { "serial", 1, QEMU_OPTION_serial }, >> + { "seriala", 1, QEMU_OPTION_seriala }, >> + { "serialb", 1, QEMU_OPTION_serialb }, > > There is no real need to do this: qemu can handle several -serial > options fine. > >> diff -ur xen-3.1-3.1.0/tools/python/xen/xm/create.py >> xen-3.1-3.1.0-my/tools/python/xen/xm/create.py >> --- xen-3.1-3.1.0/tools/python/xen/xm/create.py 2007-05-18 20:45:21.000000000 >> +0600 >> +++ xen-3.1-3.1.0-my/tools/python/xen/xm/create.py 2007-12-30 >> 19:25:57.000000000 +0500 >> -gopts.var(''serial'', val=''FILE'', > > And that could be a list of serial/pty/vc/... > > Samuel > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel