Xen devel - Dec 2007 - [PATCH][LINUX] Dynamic modes support for PV xenfb

Attached patch adds multiple frame buffer resolution support to 
the PV xenfb frame buffer driver.

Code is essentially the same as I sent in the previous RFC except
the frame buffer size is now 800x600 if the backend does not
support feature-resize,  same memory footprint.

Corresponding backend IOEMU patch is required for functionality but 
this patch is not dependent on it, preserving backwards compatibility.

Please apply to tip of linux-2.6.18-xen

Signed-     off-     by: Pat Campbell <plc@novell.com>







_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Fri, Dec 28, 2007 at 11:33:17AM -0700, Pat Campbell wrote:
> Attached patch adds multiple frame buffer resolution support to 
> the PV xenfb frame buffer driver.
Note this change will need an update to:

http://wiki.xensource.com/xenwiki/APIChangelog

if/when it goes in.

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

>>> On Fri, Dec 28, 2007 at 12:00 PM, in message
<20071228190018.GB8404@totally.trollied.org.uk>, John Levon
<levon@movementarian.org> wrote: 
> On Fri, Dec 28, 2007 at 11:33:17AM -   0700, Pat Campbell wrote:
> 
>> Attached patch adds multiple frame buffer resolution support to 
>> the PV xenfb frame buffer driver.
> 
> Note this change will need an update to:
> 
> http://wiki.xensource.com/xenwiki/APIChangelog
> 
> if/when it goes in.
> 
> regards
> john
John,

I read the page at the included wiki link.  This patch is backwards 
compatible and "should not" present any cross-OS compatibility
issues.  Resolution change, if any, is driven by the guest OS.

I am not adversed to documenting the change but not sure
it is an API change.

Pat   




_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Sun, Dec 30, 2007 at 02:10:09PM -0700, Pat Campbell wrote:
> >> Attached patch adds multiple frame buffer resolution support to 
> >> the PV xenfb frame buffer driver.
> > 
> > Note this change will need an update to:
> > 
> > http://wiki.xensource.com/xenwiki/APIChangelog
> > 
> > if/when it goes in.
> 
> John,
> 
> I read the page at the included wiki link.  This patch is backwards 
> compatible and "should not" present any cross-OS compatibility
> issues.  Resolution change, if any, is driven by the guest OS.
> 
> I am not adversed to documenting the change but not sure
> it is an API change.
An addition is a change, just not an incompatible one.

regards,
john

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

John Levon writes ("Re: [Xen-devel][PATCH][LINUX] Dynamic modes support for
PV xenfb"):
> On Fri, Dec 28, 2007 at 11:33:17AM -0700, Pat Campbell wrote:
> > Attached patch adds multiple frame buffer resolution support to 
> > the PV xenfb frame buffer driver.
> 
> Note this change will need an update to:
>  http://wiki.xensource.com/xenwiki/APIChangelog
> if/when it goes in.
Should we have asked Pat Campbell to include the text for the API
changelog in the patch submission ?

Something like:

   Attached patch adds multiple frame buffer size support [etc.]

   Please apply to tip of xen-unstable

   API Changelog entry:
	Framebuffer resize facility::

	Guest may send XENFB_TYPE_RESIZE if feature-resize = 1 in
	xenstore.  [add some text about supported sizes]

   Signed-off-by: [etc]

If we put the new API changelog entry right there in the message, just
before Signed-off-by, it will be easy to spot it and paste it across
if and when the patch is committed.

(I''ve edited the APIChangelog wiki page to put recent entries first.)

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Wed, Jan 02, 2008 at 11:08:08AM +0000, Ian Jackson wrote:
> > > Attached patch adds multiple frame buffer resolution support to 
> > > the PV xenfb frame buffer driver.
> > 
> > Note this change will need an update to:
> >  http://wiki.xensource.com/xenwiki/APIChangelog
> > if/when it goes in.
> 
> Should we have asked Pat Campbell to include the text for the API
> changelog in the patch submission ?
Sounds like an excellent idea.

regards,
john

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 2/1/08 19:01, "John Levon" <levon@movementarian.org> wrote:
>>> Note this change will need an update to:
>>>  http://wiki.xensource.com/xenwiki/APIChangelog
>>> if/when it goes in.
>> 
>> Should we have asked Pat Campbell to include the text for the API
>> changelog in the patch submission ?
> 
> Sounds like an excellent idea.
Even better maybe just have the changelog as a file within the xen
repository? Then patches can just modify the changelog file. Conflicts
between patches will easily be resolved. The chances of me picking out and
cut&pasting from a patch header into a wiki text box are zero.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Sun, Jan 06, 2008 at 10:54:28PM +0000, Keir Fraser wrote:
> >>> Note this change will need an update to:
> >>>  http://wiki.xensource.com/xenwiki/APIChangelog
> >>> if/when it goes in.
> >> 
> >> Should we have asked Pat Campbell to include the text for the API
> >> changelog in the patch submission ?
> > 
> > Sounds like an excellent idea.
> 
> Even better maybe just have the changelog as a file within the xen
> repository? Then patches can just modify the changelog file. Conflicts
> between patches will easily be resolved. The chances of me picking out and
> cut&pasting from a patch header into a wiki text box are zero.
Also fine (Ian suggested it before). Want a patch to put what we''ve got
already into the tree?

regards
john

PS the idea was that you''d make the submitted add it not that
you''d do
it!

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 6/1/08 23:00, "John Levon" <levon@movementarian.org> wrote:
>>> Sounds like an excellent idea.
>> 
>> Even better maybe just have the changelog as a file within the xen
>> repository? Then patches can just modify the changelog file. Conflicts
>> between patches will easily be resolved. The chances of me picking out
and
>> cut&pasting from a patch header into a wiki text box are zero.
> 
> Also fine (Ian suggested it before). Want a patch to put what
we''ve got
> already into the tree?
Sure.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel