Paul Samon
2007-Dec-13 10:23 UTC
[Xen-devel] Duplicate __HYPERVISOR_grant_table_op in hvm_hypercall32_table?
In xen/arch/x86/hvm/hvm.c:
#define HYPERCALL(x) \
[ __HYPERVISOR_ ## x ] = (hvm_hypercall_t *) do_ ## x
#if defined(__i386__)
static hvm_hypercall_t *hvm_hypercall32_table[NR_hypercalls] = {
HYPERCALL(memory_op),
[ __HYPERVISOR_grant_table_op ] = (hvm_hypercall_t *)hvm_grant_table_op,
HYPERCALL(xen_version),
HYPERCALL(grant_table_op),
HYPERCALL(event_channel_op),
HYPERCALL(sched_op),
HYPERCALL(hvm_op)
};
#else /* defined(__x86_64__) */
-------------------
For the index __HYPERVISOR_grant_table_op, there are 2 assignments --
do_grant_table_op(), and hvm_grant_table_op() here???
What''s the purpose by doing so?
--
-- Paul S.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Keir Fraser
2007-Dec-13 11:04 UTC
Re: [Xen-devel] Duplicate __HYPERVISOR_grant_table_op in hvm_hypercall32_table?
The assignment of do_grant_table_op() is bogus. I¹ll remove it. Thanks, Keir On 13/12/07 10:23, "Paul Samon" <paul.samon@gmail.com> wrote:> In xen/arch/x86/hvm/hvm.c: > #define HYPERCALL(x) \ > [ __HYPERVISOR_ ## x ] = (hvm_hypercall_t *) do_ ## x > > #if defined(__i386__) > > static hvm_hypercall_t *hvm_hypercall32_table[NR_hypercalls] = { > HYPERCALL(memory_op), > [ __HYPERVISOR_grant_table_op ] = (hvm_hypercall_t *)hvm_grant_table_op, > HYPERCALL(xen_version), > HYPERCALL(grant_table_op), > HYPERCALL(event_channel_op), > HYPERCALL(sched_op), > HYPERCALL(hvm_op) > }; > > #else /* defined(__x86_64__) */ > ------------------- > For the index __HYPERVISOR_grant_table_op, there are 2 assignments -- > do_grant_table_op(), and hvm_grant_table_op() here??? > What''s the purpose by doing so?_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel