Hi all.
cli # tests must not race interrupts
/*test_softirqs:*/
movl VCPU_processor(%ebx),%eax
shl $IRQSTAT_shift,%eax
test %ecx,irq_stat(%eax,1)
jnz process_softirqs
btr $_VCPUF_nmi_pending,VCPU_flags(%ebx) <<--- we are here
jc process_nmi
Taken from xen-3.0.2. The code may be outdated anyway, but doesn''t the
btr lack a lock prefix on SMP?
regards,
daniel
--
dns@somacoma.net
Wire up your home and stay there.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
> cli # tests must not race interrupts >/*test_softirqs:*/ > movl VCPU_processor(%ebx),%eax > shl $IRQSTAT_shift,%eax > test %ecx,irq_stat(%eax,1) > jnz process_softirqs > btr $_VCPUF_nmi_pending,VCPU_flags(%ebx) <<--- we are here > jc process_nmi > >Taken from xen-3.0.2. The code may be outdated anyway, but doesn''t the >btr lack a lock prefix on SMP?Yes, it was lacking a lock, but no, the code isn''t there anymore in a shape close to that. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Thu, 2007-12-06 at 16:48 +0000, Jan Beulich wrote:> >Taken from xen-3.0.2. The code may be outdated anyway, but doesn''t the > >btr lack a lock prefix on SMP? > > Yes, it was lacking a lock, but no, the code isn''t there anymore in a shape > close to that.Thanks, just curious. Daniel -- dns@somacoma.net Wire up your home and stay there. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel