Kouya Shimura
2007-Nov-27 04:24 UTC
[Xen-devel] [PATCH][Linux] Fix access to xenstore hangs after hotremove CPU
Hi, CPU hotplug doesn''t support user-space event channels. $ echo 0 > /sys/devices/system/cpu/cpu1/online $ xenstore-ls ... hangs up ... Attached patch fixes it. Thanks, Kouya Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2007-Nov-27 08:03 UTC
Re: [Xen-devel] [PATCH][Linux] Fix access to xenstore hangs afterhotremove CPU
Using __cpuinitdata (or __cpuinit) in #ifdef CONFIG_HOTPLUG_CPU sections is pointless. Either remove the #ifdef-s (and mark evtchn_cpu_notify() __cpuinit) or remove the __cpuinitdata. I think the former is the preferred upstream approach. Jan>>> Kouya Shimura <kouya@jp.fujitsu.com> 27.11.07 05:24 >>>Hi, CPU hotplug doesn''t support user-space event channels. $ echo 0 > /sys/devices/system/cpu/cpu1/online $ xenstore-ls ... hangs up ... Attached patch fixes it. Thanks, Kouya Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Kouya Shimura
2007-Nov-27 10:36 UTC
[Xen-devel] [PATCH][Linux] Fix access to xenstore hangs afterhotremove CPU
I see. Thanks for pointing out. Revised patch attached. Thanks, Kouya Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com> Jan Beulich writes: > Using __cpuinitdata (or __cpuinit) in #ifdef CONFIG_HOTPLUG_CPU sections > is pointless. Either remove the #ifdef-s (and mark evtchn_cpu_notify() > __cpuinit) or remove the __cpuinitdata. I think the former is the preferred > upstream approach. > > Jan > > >>> Kouya Shimura <kouya@jp.fujitsu.com> 27.11.07 05:24 >>> > Hi, > > CPU hotplug doesn''t support user-space event channels. > > $ echo 0 > /sys/devices/system/cpu/cpu1/online > $ xenstore-ls > ... hangs up ... > > Attached patch fixes it. > > Thanks, > Kouya > > Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com> > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel