# HG changeset patch
# User john.levon@sun.com
# Date 1194905356 28800
# Node ID 695e38fa5029bafc9ee9fc08dc4fe3cbec5a7489
# Parent 8b787636c4ac1b0e303c86ed489d91a63626a17e
Fix non-portable grep usage
grep -q doesn''t exist on the default Solaris grep.
Signed-off-by: John Levon <john.levon@sun.com>
diff --git a/tools/firmware/rombios/32bit/Makefile
b/tools/firmware/rombios/32bit/Makefile
--- a/tools/firmware/rombios/32bit/Makefile
+++ b/tools/firmware/rombios/32bit/Makefile
@@ -34,7 +34,7 @@ clean:
$(TARGET): subdirs 32bitbios.o util.o
$(LD) $(LDFLAGS_DIRECT) -s -r 32bitbios.o $(MODULES) util.o -o 32bitbios_all.o
@nm 32bitbios_all.o | \
- grep -E -q ''^ +U '' && {
\
+ egrep ''^ +U '' 2>/dev/null && {
\
echo "There are undefined symbols in the BIOS:"; \
nm -u 32bitbios_all.o; \
exit 11; \
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
john.levon@sun.com writes ("[Xen-devel] [PATCH] Fix non-portable grep
usage"):> - grep -E -q ''^ +U '' && {
\
> + egrep ''^ +U '' 2>/dev/null && {
\
-q suppresses stdout output, not stderr. So I think you mean:
+ egrep ''^ +U '' >/dev/null && {
\
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
On Tue, Nov 13, 2007 at 10:01:53AM +0000, Ian Jackson wrote:> john.levon@sun.com writes ("[Xen-devel] [PATCH] Fix non-portable grep usage"): > > - grep -E -q ''^ +U '' && { \ > > + egrep ''^ +U '' 2>/dev/null && { \ > > -q suppresses stdout output, not stderr. So I think you mean: > + egrep ''^ +U '' >/dev/null && { \Right, thanks (I didn''t see any output, obviously, so missed this) regards john _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel