Hi! Changeset 16250 is not portable. On BSD I get these build errors: /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:19:25: error: linux/input.h: No such file or directory /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c: In function ''xenfb_mouse_event'': /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: ''BTN_LEFT'' undeclared (first use in this function) /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: (Each undeclared identifier is reported only once /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: for each function it appears in.) -- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
I think John Levon''s recent patch might fix this. I''m going to go through and check in most or all of it I expect. -- Keir On 2/11/07 09:12, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> > Hi! > > Changeset 16250 is not portable. On BSD I get these build errors: > > /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:19:25: error: > linux/input.h: No such file or directory > /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c: In > function ''xenfb_mouse_event'': > /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: ''BTN_LEFT'' > undeclared (first use in this function) > /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: (Each > undeclared identifier is reported only once > /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: for each > function it appears in.) > > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Friday 02 November 2007 10:12:39 Christoph Egger wrote:> Hi! > > Changeset 16250 is not portable. On BSD I get these build errors:It''s not changeset 16250. The non-portable issue is thre from the beginning. When I comment out line 19 and lines 1039,1040 then ioemu builds again for me. Daniel: Please file a patch to get rid of the BTN_LEFT and the linux/input.h header.> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:19:25: error: > linux/input.h: No such file or directory > /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c: In > function ''xenfb_mouse_event'': > /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: ''BTN_LEFT'' > undeclared (first use in this function) > /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: (Each > undeclared identifier is reported only once > /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: for each > function it appears in.)-- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
I''m testing John Levon''s patch. On Friday 02 November 2007 10:19:08 Keir Fraser wrote:> I think John Levon''s recent patch might fix this. I''m going to go through > and check in most or all of it I expect. > > -- Keir > > On 2/11/07 09:12, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > Hi! > > > > Changeset 16250 is not portable. On BSD I get these build errors: > > > > /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:19:25: error: > > linux/input.h: No such file or directory > > /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c: In > > function ''xenfb_mouse_event'': > > /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: > > ''BTN_LEFT'' undeclared (first use in this function) > > /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: (Each > > undeclared identifier is reported only once > > /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: for each > > function it appears in.)-- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Actually I liked your suggestion better for this particular issue, so I checked it in. -- Keir On 2/11/07 09:28, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> > I''m testing John Levon''s patch. > > > On Friday 02 November 2007 10:19:08 Keir Fraser wrote: >> I think John Levon''s recent patch might fix this. I''m going to go through >> and check in most or all of it I expect. >> >> -- Keir >> >> On 2/11/07 09:12, "Christoph Egger" <Christoph.Egger@amd.com> wrote: >>> Hi! >>> >>> Changeset 16250 is not portable. On BSD I get these build errors: >>> >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:19:25: error: >>> linux/input.h: No such file or directory >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c: In >>> function ''xenfb_mouse_event'': >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: >>> ''BTN_LEFT'' undeclared (first use in this function) >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: (Each >>> undeclared identifier is reported only once >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: for each >>> function it appears in.) > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Friday 02 November 2007 10:28:33 Christoph Egger wrote:> I''m testing John Levon''s patch.Works for me.> > On Friday 02 November 2007 10:19:08 Keir Fraser wrote: > > I think John Levon''s recent patch might fix this. I''m going to go through > > and check in most or all of it I expect. > > > > -- Keir > > > > On 2/11/07 09:12, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > > Hi! > > > > > > Changeset 16250 is not portable. On BSD I get these build errors: > > > > > > /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:19:25: error: > > > linux/input.h: No such file or directory > > > /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c: In > > > function ''xenfb_mouse_event'': > > > /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: > > > ''BTN_LEFT'' undeclared (first use in this function) > > > /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: (Each > > > undeclared identifier is reported only once > > > /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: for > > > each function it appears in.)-- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Friday 02 November 2007 10:45:15 Keir Fraser wrote:> Actually I liked your suggestion better for this particular issue, so I > checked it in.I just tested changest 16306 and works fine with me. Thanks. Christoph> -- Keir > > On 2/11/07 09:28, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > I''m testing John Levon''s patch. > > > > On Friday 02 November 2007 10:19:08 Keir Fraser wrote: > >> I think John Levon''s recent patch might fix this. I''m going to go > >> through and check in most or all of it I expect. > >> > >> -- Keir > >> > >> On 2/11/07 09:12, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > >>> Hi! > >>> > >>> Changeset 16250 is not portable. On BSD I get these build errors: > >>> > >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:19:25: error: > >>> linux/input.h: No such file or directory > >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c: In > >>> function ''xenfb_mouse_event'': > >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: > >>> ''BTN_LEFT'' undeclared (first use in this function) > >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: (Each > >>> undeclared identifier is reported only once > >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: for > >>> each function it appears in.)-- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Fri, Nov 02, 2007 at 11:12:39AM +0200, Christoph Egger wrote:> > Hi! > > Changeset 16250 is not portable. On BSD I get these build errors:I guess you never compiled the xenfb stuff on BSD at all in the past ? I didn''t introduce any new deps that weren''t already in the xenfb code. Kier''s change looks reasonable to me though. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Friday 02 November 2007 14:38:57 Daniel P. Berrange wrote:> On Fri, Nov 02, 2007 at 11:12:39AM +0200, Christoph Egger wrote: > > Hi! > > > > Changeset 16250 is not portable. On BSD I get these build errors: > > I guess you never compiled the xenfb stuff on BSD at all in the past ? > I didn''t introduce any new deps that weren''t already in the xenfb code. > Kier''s change looks reasonable to me though.If it was there before, then it must have been disabled (by default). Otherwise, I would have noticed earlier. Christoph -- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel