Daniel P. Berrange
2007-May-17 22:09 UTC
[Xen-devel] PATCH: Teardown domain if device hotplug fails during startup
If creating an unmanaged guest (eg xm create), if device hotplug fails during
the startup of the guest, then the guest will be torn down again. If creating
and starting a managed guest (eg xm new && xm start), then if device
hotplug
fails, the still born guest gets left in ''paused'' state. This
confuses users
no end, who go an unpause and then get all upset when it shortly crashes (due
to lack of disk or network devices)
The attached patch fixes XenDomain.py''s domain_start() method so that
if
waitForDevices() fails, then the entire domain is torn down. This is the
same approach used in xm create.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Before:
# xm start fc6pvtest
Error: Device 0 (vif) could not be connected. Hotplug scripts not working.
Usage: xm start <DomainName>
Start a Xend managed domain
-p, --paused Do not unpause domain after starting it
# xm list
Name ID Mem VCPUs State Time(s)
Domain-0 0 3516 2 r----- 128.9
fc6pvtest 3 500 1 --p--- 0.0
After:
# xm start fc6pvtest
Error: Device 0 (vif) could not be connected. Hotplug scripts not working.
Usage: xm start <DomainName>
Start a Xend managed domain
-p, --paused Do not unpause domain after starting it
# xm list
Name ID Mem VCPUs State Time(s)
Domain-0 0 3516 2 r----- 128.9
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel