Petersson, Mats
2007-May-17 14:35 UTC
[Xen-devel] [PATCH][IOEMU]Attempt to setup tap interface up to 3 times.
Resend: Now with patch attached. As there is a (small) chance that vl.c:tap_open() fails (due to some sort of race-condition in the Linux kernel, which is noted as a bug in the source .../net/core/dev.c), we should attempt it again a couple of times if it doesn''t succeed on the first attempt. I think three times in total is sufficient to avoid the problem. If tap_open() fails, qemu-dm will exit, which means that the domain dies - which is not such a good thing when attempting to restore a saved domain [of course, it would be even worse if it started, but didn''t have networking - because there may not be a way to shut it down cleanly without network]. Attached is an updated patch to the one I sent a few days ago, which matches the latest Xen-unstable. Signed off by: Mats Petersson (mats.petersson@amd.com) -- Mats _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Petersson, Mats
2007-May-17 14:35 UTC
[Xen-devel] [PATCH][IOEMU]Attempt to setup tap interface up to 3 times.
As there is a (small) chance that vl.c:tap_open() fails (due to some sort of race-condition in the Linux kernel, which is noted as a bug in the source .../net/core/dev.c), we should attempt it again a couple of times if it doesn''t succeed on the first attempt. I think three times in total is sufficient to avoid the problem. If tap_open() fails, qemu-dm will exit, which means that the domain dies - which is not such a good thing when attempting to restore a saved domain [of course, it would be even worse if it started, but didn''t have networking - because there may not be a way to shut it down cleanly without network]. Attached is an updated patch to the one I sent a few days ago, which matches the latest Xen-unstable. Signed off by: Mats Petersson (mats.petersson@amd.com) -- Mats _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel