George S. Coker, II
2007-May-07 21:41 UTC
[Xen-devel][Xense-devel][PATCH][3/4] Xen Security Modules: tools
Updates in this patch set include:
- track changes introduced by Xen-API (no Xen-API support, yet)
Signed-off-by: George Coker <gscoker@alpha.ncsc.mil>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Mark Williamson
2007-May-08 03:21 UTC
Re: [Xen-devel][Xense-devel][PATCH][3/4] Xen Security Modules: tools
Same style issues as other patches, but again we need to figure out which of the sub-styles of the Xen code we need to standardise on ;-) Cheers, Mark -- Dave: Just a question. What use is a unicyle with no seat? And no pedals! Mark: To answer a question with a question: What use is a skateboard? Dave: Skateboards have wheels. Mark: My wheel has a wheel! _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2007-May-08 07:14 UTC
Re: [Xen-devel][Xense-devel][PATCH][3/4] Xen Security Modules: tools
On 8/5/07 04:21, "Mark Williamson" <mark.williamson@cl.cam.ac.uk> wrote:> Same style issues as other patches, but again we need to figure out which of > the sub-styles of the Xen code we need to standardise on ;-)There are two styles we properly support: Xen style as in files like event_channel.c, xmalloc.c, etc.; and Linux style (generally seen in files ripped off fairly directly from Linux -- *not* used in new files). The halfway-house files usually arise from me having been too lazy to enforce Xen style when they were checked in, and generally being in bits of the tree where I don''t often venture. Seeing as we''re planning to be more strict from now on, the current ACM code style is *not* to be followed. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Mark Williamson
2007-May-08 09:40 UTC
Re: [Xen-devel][Xense-devel][PATCH][3/4] Xen Security Modules: tools
> There are two styles we properly support: Xen style as in files like > event_channel.c, xmalloc.c, etc.; and Linux style (generally seen in files > ripped off fairly directly from Linux -- *not* used in new files). The > halfway-house files usually arise from me having been too lazy to enforce > Xen style when they were checked in, and generally being in bits of the > tree where I don''t often venture.I did wonder if it was something like that ;-)> Seeing as we''re planning to be more strict from now on, the current ACM > code style is *not* to be followed.Cool, thanks for the clarification. I''ll continue running the verifier over new patches and I can submit it for inclusion in 3.0.6 - once I''ve finished teaching it the difference between Xen and Linux. Then folks will be able to run it over submitted code as a sanity test. Cheers, Mark -- Dave: Just a question. What use is a unicyle with no seat? And no pedals! Mark: To answer a question with a question: What use is a skateboard? Dave: Skateboards have wheels. Mark: My wheel has a wheel! _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
George S. Coker, II
2007-May-08 10:23 UTC
Re: [Xen-devel][Xense-devel][PATCH][3/4] Xen Security Modules: tools
I''ll reformat the patches. On 5/8/07, Mark Williamson <mark.williamson@cl.cam.ac.uk> wrote:> > There are two styles we properly support: Xen style as in files like > > event_channel.c, xmalloc.c, etc.; and Linux style (generally seen in files > > ripped off fairly directly from Linux -- *not* used in new files). The > > halfway-house files usually arise from me having been too lazy to enforce > > Xen style when they were checked in, and generally being in bits of the > > tree where I don''t often venture. > > I did wonder if it was something like that ;-) > > > Seeing as we''re planning to be more strict from now on, the current ACM > > code style is *not* to be followed. > > Cool, thanks for the clarification. I''ll continue running the verifier over > new patches and I can submit it for inclusion in 3.0.6 - once I''ve finished > teaching it the difference between Xen and Linux. Then folks will be able to > run it over submitted code as a sanity test. > > Cheers, > Mark > > -- > Dave: Just a question. What use is a unicyle with no seat? And no pedals! > Mark: To answer a question with a question: What use is a skateboard? > Dave: Skateboards have wheels. > Mark: My wheel has a wheel! > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
George S. Coker, II
2007-Jun-04 19:06 UTC
[Xen-devel][Xense-devel][PATCH][3/4] Xen Security Modules: tools
Updates in this patch set include:
- coding style cleanups
- new xsm module management for python tool chain:
- a module is not required to implement a "core" set of funcs
- modules may transparently implement additional funcs
- load time registration and validation of xsm funcs
- stub methods are substituted for unimplemented xsm funcs
- remove patch cruft
TODO:
- documentation of the module interfaces
Signed-off-by: George Coker <gscoker@alpha.ncsc.mil>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
George S. Coker, II
2007-Jun-06 16:11 UTC
Re: [Xen-devel][Xense-devel][PATCH][3/4] Xen Security Modules: tools
This patch fixes a small issue with the XSMError class. The class was not correctly imported into the global namespace of the modules. You only notice the problem if you invoke errors...:) Signed-off-by: George Coker <gscoker@alpha.ncsc.mil> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel