thr3ads.net - Xen devel - [Xen-devel] [PATCH] Fix sched commands for when wrong domain is given [Jan 2007]

If this information is useful, please help other people find it:
Share via:

Masaki Kanno

2007-Jan-31 02:28 UTC

[Xen-devel] [PATCH] Fix sched commands for when wrong domain is given

Hi,

I found strange issues. I gave a wrong domain name to the xm sched 
commands. The xm sched commands only showed the header at that time. 
And the xm sched-sedf command did not become an error when I tried 
to set scheduler parameters. 

# xm sched-credit -d Nonexistent-domain
Name                              ID Weight Cap 

# xm sched-sedf Nonexistent-domain
Name                              ID Period(ms) Slice(ms) Lat(ms) Extra Weight
# xm sched-sedf Nonexistent-domain -w 10
# 


I fixed it. When the wrong domain name is given, the xm sched 
commands show the following error messages. 

# xm sched-credit -d Nonexistent-domain
Error: Domain ''Nonexistent-domain'' does not exist.
Usage: xm sched-credit [-d <Domain> [-w[=WEIGHT]|-c[=CAP]]]

Get/set credit scheduler parameters.
  -d DOMAIN, --domain=DOMAIN     Domain to modify 
  -w WEIGHT, --weight=WEIGHT     Weight (int) 
  -c CAP, --cap=CAP              Cap (int) 

# xm sched-sedf Nonexistent-domain
Error: Domain ''Nonexistent-domain'' does not exist.
Usage: xm sched-sedf <Domain> [options]

Get/set EDF parameters.
  -p [MS], --period[=MS]         Relative deadline(ms) 
  -s [MS], --slice[=MS]          Worst-case execution time(ms). (slice < 
                                 period)
  -l [MS], --latency[=MS]        Scaled period (ms) when domain performs 
                                 heavy I/O
  -e [FLAG], --extra[=FLAG]      Flag (0 or 1) controls if domain can run 
                                 in extra time.
  -w [FLOAT], --weight[=FLOAT]   CPU Period/slice (do not set with 
                                 --period/--slice)

# xm sched-sedf Nonexistent-domain -w 10
Error: Domain ''Nonexistent-domain'' does not exist.
Usage: xm sched-sedf <Domain> [options]

Get/set EDF parameters.
  -p [MS], --period[=MS]         Relative deadline(ms) 
  -s [MS], --slice[=MS]          Worst-case execution time(ms). (slice < 
                                 period)
  -l [MS], --latency[=MS]        Scaled period (ms) when domain performs 
                                 heavy I/O
  -e [FLAG], --extra[=FLAG]      Flag (0 or 1) controls if domain can run 
                                 in extra time.
  -w [FLOAT], --weight[=FLOAT]   CPU Period/slice (do not set with 
                                 --period/--slice)


Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com>

Best regards,
 Kan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Ewan Mellor

2007-Feb-06 16:05 UTC

head link

Re: [Xen-devel] [PATCH] Fix sched commands for when wrong domain is given

On Wed, Jan 31, 2007 at 11:28:39AM +0900, Masaki Kanno wrote:

Content-Description: Mail message body> Hi,
> 
> I found strange issues. I gave a wrong domain name to the xm sched 
> commands. The xm sched commands only showed the header at that time. 
> And the xm sched-sedf command did not become an error when I tried 
> to set scheduler parameters. 
> 
> # xm sched-credit -d Nonexistent-domain
> Name                              ID Weight Cap 
> 
> # xm sched-sedf Nonexistent-domain
> Name                              ID Period(ms) Slice(ms) Lat(ms) Extra
Weight
> # xm sched-sedf Nonexistent-domain -w 10
> # 
> 
> 
> I fixed it. When the wrong domain name is given, the xm sched 
> commands show the following error messages. 
> 
> # xm sched-credit -d Nonexistent-domain
> Error: Domain ''Nonexistent-domain'' does not exist.
> Usage: xm sched-credit [-d <Domain> [-w[=WEIGHT]|-c[=CAP]]]
> 
> Get/set credit scheduler parameters.
>   -d DOMAIN, --domain=DOMAIN     Domain to modify 
>   -w WEIGHT, --weight=WEIGHT     Weight (int) 
>   -c CAP, --cap=CAP              Cap (int) 
> 
> # xm sched-sedf Nonexistent-domain
> Error: Domain ''Nonexistent-domain'' does not exist.
> Usage: xm sched-sedf <Domain> [options]
> 
> Get/set EDF parameters.
>   -p [MS], --period[=MS]         Relative deadline(ms) 
>   -s [MS], --slice[=MS]          Worst-case execution time(ms). (slice <
>                                  period)
>   -l [MS], --latency[=MS]        Scaled period (ms) when domain performs 
>                                  heavy I/O
>   -e [FLAG], --extra[=FLAG]      Flag (0 or 1) controls if domain can run 
>                                  in extra time.
>   -w [FLOAT], --weight[=FLOAT]   CPU Period/slice (do not set with 
>                                  --period/--slice)
> 
> # xm sched-sedf Nonexistent-domain -w 10
> Error: Domain ''Nonexistent-domain'' does not exist.
> Usage: xm sched-sedf <Domain> [options]
> 
> Get/set EDF parameters.
>   -p [MS], --period[=MS]         Relative deadline(ms) 
>   -s [MS], --slice[=MS]          Worst-case execution time(ms). (slice <
>                                  period)
>   -l [MS], --latency[=MS]        Scaled period (ms) when domain performs 
>                                  heavy I/O
>   -e [FLAG], --extra[=FLAG]      Flag (0 or 1) controls if domain can run 
>                                  in extra time.
>   -w [FLOAT], --weight[=FLOAT]   CPU Period/slice (do not set with 
>                                  --period/--slice)
> 
> 
> Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com>
Applied, thank you.

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Xen devel - Jan 2007 - [PATCH] Fix sched commands for when wrong domain is given

[Xen-devel] [PATCH] Fix sched commands for when wrong domain is given

Re: [Xen-devel] [PATCH] Fix sched commands for when wrong domain is given