Christoph Egger
2007-Jan-29 14:25 UTC
[Xen-devel] [PATCH 1/3] Use string bound functions (take #2)
arch independent code. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Anil Madhavapeddy
2007-Jan-29 14:37 UTC
Re: [Xen-devel] [PATCH 1/3] Use string bound functions (take #2)
I notice these aren''t checking for buffer truncation. Might be worth putting checks for this in places where it matters and not silently truncate the string (e.g. the domain builder). -anil On 29 Jan 2007, at 14:25, Christoph Egger wrote:> <xen_stringbound.diff>_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2007-Jan-29 14:51 UTC
Re: [Xen-devel] [PATCH 1/3] Use string bound functions (take #2)
On Monday 29 January 2007 15:37, Anil Madhavapeddy wrote:> I notice these aren''t checking for buffer truncation. Might be worth > putting checks for this in places where it matters and not silently > truncate the string (e.g. the domain builder).Yeah. I think, this should be done in another patch. Most important is, that strlcpy() is used rather strncpy(). Christoph> > -anil > > On 29 Jan 2007, at 14:25, Christoph Egger wrote: > > <xen_stringbound.diff>_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel