Hi! Where virt_to_maddr() or __pa() is used, paddr_t is mostly expected rather unsigned long. This may fix random issues in PAE mode. Christoph _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 24/1/07 09:06, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> Where virt_to_maddr() or __pa() is used, paddr_t is mostly expected rather > unsigned long. This may fix random issues in PAE mode.They''re only used on Xen heap virtual addresses whose physical addresses are always below 64MB. So there should be no issues in returning a ulong. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Wednesday 24 January 2007 11:48, Keir Fraser wrote:> On 24/1/07 09:06, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > Where virt_to_maddr() or __pa() is used, paddr_t is mostly expected > > rather unsigned long. This may fix random issues in PAE mode. > > They''re only used on Xen heap virtual addresses whose physical addresses > are always below 64MB. So there should be no issues in returning a ulong.Oh, I see. So it''s absolutely not used for domains (which I assumed)? Christoph _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 24/1/07 11:01, "Christoph Egger" <Christoph.Egger@amd.com> wrote:>> They''re only used on Xen heap virtual addresses whose physical addresses >> are always below 64MB. So there should be no issues in returning a ulong. > > Oh, I see. So it''s absolutely not used for domains (which I assumed)?No, all it does is a simple arithmetic transformation (subtracting PAGE_OFFSET) which is only valid for non-guest pages on x86_32. It can be used for any page on x86_64, but there we have paddr_t==ulong. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel