Tomonari Horikoshi
2007-Jan-24 01:37 UTC
[Xen-ia64-devel] [PATCH] Add netfornt tx_queue_len
Thank you for your comment. ( -> Isaku Yamahata) Isaku Yamahata wrote:---------------------- Sent: Tue, 23 Jan 2007 22:29:47 +0900 Subject: Re: [Xen-ia64-devel] [PATCH] Add netfornt tx_queue_len> > The patch modifis common-code, not ia64 specific. > You should send it to xen-devel with Cc to xen-ia64-devel. >---------------------------------------------- Hi all. When I executed "netperf" by a short message of UDP, PV domain and PV-on-HVM driver issued Call trace. I think that GrantEntry was filled with a lot of messages processings. This problem is generated in IA64 only. Probably, I think that I am the following problems. In IA64 NET_TX_RING_SIZE 1024, NR_GRANT_ENTRIES 2048 In x86 NET_TX_RING_SIZE 256, NR_GRANT_ENTRIES 2048 I corrected to check "number of unprocessing queue > tx_queue_len" before Grant was filled. However, my correction influences x86. Please teach to me in that when there is a better improvement. -------------------- # ./netperf -t UDP_STREAM -H 10.34.179.101 -l 3 -- -m 10 -M 10 netperf[2474]: bugcheck! 0 [1] Modules linked in: Pid: 2474, CPU 0, comm: netperf psr : 00001010081a2010 ifs : 8000000000000b9b ip : [<a0000001006c9ce0>] Not tainted ip is at network_start_xmit+0xa00/0xe40 unat: 0000000000000000 pfs : 8000000000000b9b rsc : 000000000000000b rnat: 0000000000000000 bsps: 0000000000000000 pr : 0104682415669999 ldrs: 0000000000000000 ccv : 0000000000000000 fpsr: 0009804c8a70033f csd : 0000000000000000 ssd : 0000000000000000 -------------------- Best regards, Tomonari Horikoshi _______________________________________________ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
On Wed, Jan 24, 2007 at 01:37:55AM +0000, Tomonari Horikoshi wrote:> > When I executed "netperf" by a short message of UDP, > PV domain and PV-on-HVM driver issued Call trace. > > I think that GrantEntry was filled with a lot of messages processings. > > This problem is generated in IA64 only. > Probably, I think that I am the following problems. > > In IA64 > NET_TX_RING_SIZE 1024, NR_GRANT_ENTRIES 2048 > In x86 > NET_TX_RING_SIZE 256, NR_GRANT_ENTRIES 2048 > > I corrected to check "number of unprocessing queue > tx_queue_len" before Grant was filled. > > However, my correction influences x86. > Please teach to me in that when there is a better improvement.Sorry, but this patch looks bogus. The tx queue is maintained by Linux and has nothing to do with the driver. So limiting its length based on internal state of the driver can''t be right. We need to find out what''s really going wrong with the grant table entries here. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tomonari Horikoshi
2007-Jan-25 04:44 UTC
[Xen-ia64-devel] Re: [Xen-devel] [PATCH] Add netfornt tx_queue_len
Hi Herbert-san Thank you for your comment. I agreed. I examine the another way. It is likely to go well if something is added to the check on netfront_tx_slot_available(). Best regards. Tomonari Horikoshi, Herbert Xu wrote:---------------------- Sent: Wed, 24 Jan 2007 13:29:51 +1100 Subject: Re: [Xen-devel] [PATCH] Add netfornt tx_queue_len> On Wed, Jan 24, 2007 at 01:37:55AM +0000, Tomonari Horikoshi wrote: > > > > When I executed "netperf" by a short message of UDP, > > PV domain and PV-on-HVM driver issued Call trace. > > > > I think that GrantEntry was filled with a lot of messages processings. > > > > This problem is generated in IA64 only. > > Probably, I think that I am the following problems. > > > > In IA64 > > NET_TX_RING_SIZE 1024, NR_GRANT_ENTRIES 2048 > > In x86 > > NET_TX_RING_SIZE 256, NR_GRANT_ENTRIES 2048 > > > > I corrected to check "number of unprocessing queue > tx_queue_len" before Grant was filled. > > > > However, my correction influences x86. > > Please teach to me in that when there is a better improvement. > > Sorry, but this patch looks bogus. The tx queue is maintained by > Linux and has nothing to do with the driver. So limiting its length > based on internal state of the driver can''t be right. > > We need to find out what''s really going wrong with the grant table > entries here. > > Cheers, > -- > Visit Openswan at http://www.openswan.org/ > Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel