Xen devel - Jan 2007 - Re: [Xen-staging] [xen-unstable] Implement clean return from save/restore failure (so that original

On Mon, 2007-01-22 at 15:16 +0000, Xen staging patchbot-unstable wrote:
> +    /*
> +     * (x86 only) Rewrite store_mfn and console_mfn back to MFN (from
PFN).
> +     */
> +#if defined(__i386__) || defined(__x86_64__)
> +    xc_dominfo_t info;
                    ^^^^
<snip>
> +#endif /* defined(__i386__) || defined(__x86_64__) */
> +
> +    /* Reset all secondary CPU states. */
> +    for ( i = 1; i <= info.max_vcpu_id; i++ )
                         ^^^^

info isn''t defined here on non-x86.  Thanks,

	Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 23/1/07 22:16, "Alex Williamson" <alex.williamson@hp.com>
wrote:
>> +    /* Reset all secondary CPU states. */
>> +    for ( i = 1; i <= info.max_vcpu_id; i++ )
>                          ^^^^
> 
> info isn''t defined here on non-x86.  Thanks,
Oops, fixed.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Wed, 2007-01-24 at 10:18 +0000, Keir Fraser wrote:
> 
> 
> On 23/1/07 22:16, "Alex Williamson"
<alex.williamson@hp.com> wrote:
> 
> >> +    /* Reset all secondary CPU states. */
> >> +    for ( i = 1; i <= info.max_vcpu_id; i++ )
> >                          ^^^^
> > 
> > info isn''t defined here on non-x86.  Thanks,
> 
> Oops, fixed.
   Thanks, but it''s not quite fixed.  The "out" label
isn''t defined for
non-x86.  This patch fixes it.  Thanks,

	Alex

Signed-off-by: Alex Williamson <alex.williamson@hp.com>
---

diff -r 259470f0856b tools/libxc/xc_resume.c
--- a/tools/libxc/xc_resume.c	Wed Jan 24 14:36:03 2007 +0000
+++ b/tools/libxc/xc_resume.c	Wed Jan 24 08:38:20 2007 -0700
@@ -58,7 +58,7 @@ static int xc_domain_resume_any(int xc_h
     if ( xc_domain_getinfo(xc_handle, domid, 1, &info) != 1 )
     {
         PERROR("Could not get domain info");
-        goto out;
+        return rc;
     }
 
     /*



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel