Keir,
smp save/restore has been reverted in the changeset 13499:
*****************************************
--- a/xen/common/domain.c Fri Jan 19 11:58:52 2007 +0000
+++ b/xen/common/domain.c Fri Jan 19 12:03:51 2007 +0000
@@ -506,14 +506,6 @@ int set_info_guest(struct domain *d,
if ( rc == 0 )
rc = arch_set_info_guest(v, c);
- /*XXX: hvm smp guest restore support */
- if ( rc == 0 &&
- v->vcpu_id != 0 &&
- is_hvm_vcpu(v) &&
- test_and_clear_bit(_VCPUF_down, &v->vcpu_flags) ) {
- vcpu_wake(v);
- }
-
domain_unpause(d);
xfree(c.nat);
******************************************
this code wake up all the aps like hvm_bringup_ap, since no IPI for ap when
restore.
if it''s slightly ugly, how about add a similar hypercall like
xc_domain_resume?
thanks,
--
best rgds,
edwin
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
On 23/1/07 15:34, "Zhai, Edwin" <edwin.zhai@intel.com> wrote:> this code wake up all the aps like hvm_bringup_ap, since no IPI for ap when > restore. > if it''s slightly ugly, how about add a similar hypercall like > xc_domain_resume?All hvm vcpu context restore should be done via the new hvm domctl, and the wakeup of APs can be implemented there (rather than in common/ directory). -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Tue, Jan 23, 2007 at 03:49:04PM +0000, Keir Fraser wrote:> All hvm vcpu context restore should be done via the new hvm domctl, and the > wakeup of APs can be implemented there (rather than in common/ directory).how about this patch? thanks,> > -- Keir >-- best rgds, edwin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 24/1/07 13:30, "Zhai, Edwin" <edwin.zhai@intel.com> wrote:>> All hvm vcpu context restore should be done via the new hvm domctl, and the >> wakeup of APs can be implemented there (rather than in common/ directory). > > how about this patch? > thanks,This new piece of code is not VMX specific. Define an hvm_load_cpu_ctxt() function which executes that new piece of code after calling the VMX/SVM specific hook function. Also you shouldn''t need to check if the vcpu is HVM, as otherwise you wouldn''t be in this function! -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
thanks for your comments, update it. thanks, On Wed, Jan 24, 2007 at 06:32:36PM +0000, Keir Fraser wrote:> On 24/1/07 13:30, "Zhai, Edwin" <edwin.zhai@intel.com> wrote: > > >> All hvm vcpu context restore should be done via the new hvm domctl, and the > >> wakeup of APs can be implemented there (rather than in common/ directory). > > > > how about this patch? > > thanks, > > This new piece of code is not VMX specific. Define an hvm_load_cpu_ctxt() > function which executes that new piece of code after calling the VMX/SVM > specific hook function. Also you shouldn''t need to check if the vcpu is HVM, > as otherwise you wouldn''t be in this function! > > -- Keir >-- best rgds, edwin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Applied, thanks. On 25/1/07 03:30, "Zhai, Edwin" <edwin.zhai@intel.com> wrote:> thanks for your comments, > update it. > > thanks, > > On Wed, Jan 24, 2007 at 06:32:36PM +0000, Keir Fraser wrote: >> On 24/1/07 13:30, "Zhai, Edwin" <edwin.zhai@intel.com> wrote: >> >>>> All hvm vcpu context restore should be done via the new hvm domctl, and the >>>> wakeup of APs can be implemented there (rather than in common/ directory). >>> >>> how about this patch? >>> thanks, >> >> This new piece of code is not VMX specific. Define an hvm_load_cpu_ctxt() >> function which executes that new piece of code after calling the VMX/SVM >> specific hook function. Also you shouldn''t need to check if the vcpu is HVM, >> as otherwise you wouldn''t be in this function! >> >> -- Keir >>_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel