Gerd Hoffmann
2007-Jan-19 09:24 UTC
[Xen-devel] unstable changeset 13416 (save restore: vcpu context support) ...
Hi, ... adds hvmcpu_context to vcpu_guest_context, thus making it binary incompatible. Is that ABI change ok? Looks like it is dom0 API only, so I think we are fine, but I think I better ask ... cheers, Gerd _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2007-Jan-19 11:40 UTC
Re: [Xen-devel] unstable changeset 13416 (save restore: vcpu context support) ...
It''s used by SMP guests when bringing up APs. So that change will have to be reverted. Thanks for spotting it! -- Keir On 19/1/07 09:24, "Gerd Hoffmann" <kraxel@novell.com> wrote:> Hi, > > ... adds hvmcpu_context to vcpu_guest_context, thus making it binary > incompatible. Is that ABI change ok? Looks like it is dom0 API only, > so I think we are fine, but I think I better ask ... > > cheers, > Gerd > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Zhai, Edwin
2007-Jan-22 02:06 UTC
Re: [Xen-devel] unstable changeset 13416 (save restore: vcpu context support) ...
On Fri, Jan 19, 2007 at 11:40:03AM +0000, Keir Fraser wrote:> > It''s used by SMP guests when bringing up APs. So that change will have to be > reverted. Thanks for spotting it!keir, could you elaborate on this? does it means SMP guest save/restore failure? thanks,> > -- Keir > > On 19/1/07 09:24, "Gerd Hoffmann" <kraxel@novell.com> wrote: > > > Hi, > > > > ... adds hvmcpu_context to vcpu_guest_context, thus making it binary > > incompatible. Is that ABI change ok? Looks like it is dom0 API only, > > so I think we are fine, but I think I better ask ... > > > > cheers, > > Gerd > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xensource.com > > http://lists.xensource.com/xen-devel > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >-- best rgds, edwin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2007-Jan-22 08:37 UTC
Re: [Xen-devel] unstable changeset 13416 (save restore: vcpu context support) ...
On 22/1/07 2:06 am, "Zhai, Edwin" <edwin.zhai@intel.com> wrote:>> It''s used by SMP guests when bringing up APs. So that change will have to be >> reverted. Thanks for spotting it! > > keir, > could you elaborate on this? does it means SMP guest save/restore failure?The change to vcpu_guest_context would have broken SMP bringup for old guests, since they know about the old layout of vcpu_guest_context. Reverting that change will have broken HVM save/restore entirely, but Tim has been making cleanups that should have fixed this again. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel