john.levon@sun.com
2007-Jan-17 02:43 UTC
[Xen-devel] [PATCH] Rename XendRoot to XendOptions
# HG changeset patch
# User john.levon@sun.com
# Date 1169005385 28800
# Node ID 3a35936342d6a1f8ebd24a54da2461b33d811496
# Parent 48b7dd3a28d7ea8fa26ea54eb337606f93433dc5
Rename XendRoot to XendOptions.
Signed-off-by: John Levon <john.levon@sun.com>
diff --git a/tools/python/xen/xend/Vifctl.py b/tools/python/xen/xend/Vifctl.py
--- a/tools/python/xen/xend/Vifctl.py
+++ b/tools/python/xen/xend/Vifctl.py
@@ -20,7 +20,7 @@
"""
import os
-import XendRoot
+import XendOptions
def network(op):
@@ -30,7 +30,7 @@ def network(op):
"""
if op not in [''start'', ''stop'']:
raise ValueError(''Invalid operation: '' + op)
- script = XendRoot.instance().get_network_script()
+ script = XendOptions.instance().get_network_script()
if script:
script.insert(1, op)
os.spawnv(os.P_WAIT, script[0], script)
diff --git a/tools/python/xen/xend/XendDomain.py
b/tools/python/xen/xend/XendDomain.py
--- a/tools/python/xen/xend/XendDomain.py
+++ b/tools/python/xen/xend/XendDomain.py
@@ -32,7 +32,7 @@ import xen.lowlevel.xc
import xen.lowlevel.xc
-from xen.xend import XendRoot, XendCheckpoint, XendDomainInfo
+from xen.xend import XendOptions, XendCheckpoint, XendDomainInfo
from xen.xend.PrettyPrint import prettyprint
from xen.xend.XendConfig import XendConfig
from xen.xend.XendError import XendError, XendInvalidDomain, VmError
@@ -51,7 +51,7 @@ from xen.xend import uuid
from xen.xend import uuid
xc = xen.lowlevel.xc.xc()
-xroot = XendRoot.instance()
+xoptions = XendOptions.instance()
__all__ = [ "XendDomain" ]
@@ -214,7 +214,7 @@ class XendDomain:
@rtype: String
@return: Path.
"""
- dom_path = xroot.get_xend_domains_path()
+ dom_path = xoptions.get_xend_domains_path()
if domuuid:
dom_path = os.path.join(dom_path, domuuid)
return dom_path
@@ -361,7 +361,7 @@ class XendDomain:
def _setDom0CPUCount(self):
"""Sets the number of VCPUs dom0 has. Retreived from the
- Xend configuration, L{XendRoot}.
+ Xend configuration, L{XendOptions}.
@requires: Expects to be protected by domains_lock.
@rtype: None
@@ -369,7 +369,7 @@ class XendDomain:
dom0 = self.privilegedDomain()
# get max number of vcpus to use for dom0 from config
- target = int(xroot.get_dom0_vcpus())
+ target = int(xoptions.get_dom0_vcpus())
log.debug("number of vcpus to use is %d", target)
# target == 0 means use all processors
@@ -1164,7 +1164,7 @@ class XendDomain:
dominfo.checkLiveMigrateMemory()
if port == 0:
- port = xroot.get_xend_relocation_port()
+ port = xoptions.get_xend_relocation_port()
try:
sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
sock.connect((dst, port))
diff --git a/tools/python/xen/xend/XendDomainInfo.py
b/tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py
+++ b/tools/python/xen/xend/XendDomainInfo.py
@@ -38,7 +38,7 @@ from xen.util import security
from xen.util import security
from xen.xend import balloon, sxp, uuid, image, arch, osdep
-from xen.xend import XendRoot, XendNode, XendConfig
+from xen.xend import XendOptions, XendNode, XendConfig
from xen.xend.XendConfig import scrub_password
from xen.xend.XendBootloader import bootloader
@@ -54,7 +54,7 @@ BOOTLOADER_LOOPBACK_DEVICE = ''/dev/xvdp''
BOOTLOADER_LOOPBACK_DEVICE = ''/dev/xvdp''
xc = xen.lowlevel.xc.xc()
-xroot = XendRoot.instance()
+xoptions = XendOptions.instance()
log = logging.getLogger("xend.XendDomainInfo")
#log.setLevel(logging.TRACE)
@@ -739,7 +739,7 @@ class XendDomainInfo:
''domid'': str(self.domid),
''vm'': self.vmpath,
''name'':
self.info[''name_label''],
- ''console/limit'':
str(xroot.get_console_limit() * 1024),
+ ''console/limit'':
str(xoptions.get_console_limit() * 1024),
''memory/target'':
str(self.info[''memory_static_min''] * 1024)
}
@@ -976,7 +976,7 @@ class XendDomainInfo:
self.info[''name_label''], self.domid)
self._writeVm(LAST_SHUTDOWN_REASON, ''crash'')
- if xroot.get_enable_dump():
+ if xoptions.get_enable_dump():
try:
self.dumpCore()
except XendError:
diff --git a/tools/python/xen/xend/XendNode.py
b/tools/python/xen/xend/XendNode.py
--- a/tools/python/xen/xend/XendNode.py
+++ b/tools/python/xen/xend/XendNode.py
@@ -24,7 +24,7 @@ from xen.util import Brctl
from xen.xend import uuid
from xen.xend.XendError import XendError, NetworkAlreadyConnected
-from xen.xend.XendRoot import instance as xendroot
+from xen.xend.XendOptions import instance as xendoptions
from xen.xend.XendStorageRepository import XendStorageRepository
from xen.xend.XendLogging import log
from xen.xend.XendPIF import *
@@ -45,7 +45,7 @@ class XendNode:
"""
self.xc = xen.lowlevel.xc.xc()
- self.state_store = XendStateStore(xendroot().get_xend_state_path())
+ self.state_store = XendStateStore(xendoptions().get_xend_state_path())
# load host state from XML file
saved_host = self.state_store.load_state(''host'')
diff --git a/tools/python/xen/xend/XendRoot.py
b/tools/python/xen/xend/XendOptions.py
rename from tools/python/xen/xend/XendRoot.py
rename to tools/python/xen/xend/XendOptions.py
--- a/tools/python/xen/xend/XendOptions.py
+++ b/tools/python/xen/xend/XendOptions.py
@@ -16,11 +16,11 @@
# Copyright (C) 2005 XenSource Ltd
#===========================================================================
-"""Xend root class.
-Creates the servers and handles configuration.
+"""Xend options.
+Handles configuration.
Other classes get config variables by importing this module,
-using instance() to get a XendRoot instance, and then
+using instance() to get a XendOptions instance, and then
the config functions (e.g. get_xend_port()) to get
configured values.
"""
@@ -33,8 +33,8 @@ from xen.xend import sxp, osdep, XendLog
from xen.xend import sxp, osdep, XendLogging
from xen.xend.XendError import XendError
-class XendRoot:
- """Root of the management classes."""
+class XendOptions:
+ """Configuration options."""
"""Default path to the config file."""
config_default = "/etc/xen/xend-config.sxp"
@@ -116,7 +116,7 @@ class XendRoot:
def _logError(self, fmt, *args):
- """Logging function to log to stderr. We use this for
XendRoot log
+ """Logging function to log to stderr. We use this for
XendOptions log
messages because they may be logged before the logger has been
configured. Other components can safely use the logger.
"""
@@ -311,12 +311,12 @@ class XendRoot:
self.vncpasswd_default)
def instance():
- """Get an instance of XendRoot.
+ """Get an instance of XendOptions.
Use this instead of the constructor.
"""
global inst
try:
inst
except:
- inst = XendRoot()
+ inst = XendOptions()
return inst
diff --git a/tools/python/xen/xend/XendProtocol.py
b/tools/python/xen/xend/XendProtocol.py
--- a/tools/python/xen/xend/XendProtocol.py
+++ b/tools/python/xen/xend/XendProtocol.py
@@ -24,7 +24,7 @@ from encode import *
from encode import *
from xen.xend import sxp
-from xen.xend import XendRoot
+from xen.xend import XendOptions
DEBUG = 0
@@ -34,7 +34,7 @@ HTTP_NO_CONTENT = 2
HTTP_NO_CONTENT = 204
-xroot = XendRoot.instance()
+xoptions = XendOptions.instance()
class XendError(RuntimeError):
@@ -218,7 +218,7 @@ class UnixXendClientProtocol(HttpXendCli
def __init__(self, path=None):
if path is None:
- path = xroot.get_xend_unix_path()
+ path = xoptions.get_xend_unix_path()
self.path = path
def makeConnection(self, _):
diff --git a/tools/python/xen/xend/balloon.py b/tools/python/xen/xend/balloon.py
--- a/tools/python/xen/xend/balloon.py
+++ b/tools/python/xen/xend/balloon.py
@@ -22,7 +22,7 @@ import xen.lowlevel.xc
import xen.lowlevel.xc
import XendDomain
-import XendRoot
+import XendOptions
from XendLogging import log
from XendError import VmError
@@ -107,11 +107,11 @@ def free(need_mem):
# usage, so we recheck the required alloc each time around the loop, but
# track the last used value so that we don''t trigger too many
watches.
- xroot = XendRoot.instance()
+ xoptions = XendOptions.instance()
xc = xen.lowlevel.xc.xc()
try:
- dom0_min_mem = xroot.get_dom0_min_mem() * 1024
+ dom0_min_mem = xoptions.get_dom0_min_mem() * 1024
retries = 0
sleep_time = SLEEP_TIME_GROWTH
diff --git a/tools/python/xen/xend/image.py b/tools/python/xen/xend/image.py
--- a/tools/python/xen/xend/image.py
+++ b/tools/python/xen/xend/image.py
@@ -464,14 +464,14 @@ class HVMImageHandler(ImageHandler):
vnclisten = imageConfig.get(''vnclisten'')
if not(vnclisten):
- vnclisten = (xen.xend.XendRoot.instance().
+ vnclisten = (xen.xend.XendOptions.instance().
get_vnclisten_address())
if vnclisten:
ret += [''-vnclisten'', vnclisten]
vncpasswd = vncpasswd_vmconfig
if vncpasswd is None:
- vncpasswd = (xen.xend.XendRoot.instance().
+ vncpasswd = (xen.xend.XendOptions.instance().
get_vncpasswd_default())
if vncpasswd is None:
raise VmError(''vncpasswd is not set up in
'' +
diff --git a/tools/python/xen/xend/server/DevController.py
b/tools/python/xen/xend/server/DevController.py
--- a/tools/python/xen/xend/server/DevController.py
+++ b/tools/python/xen/xend/server/DevController.py
@@ -19,7 +19,7 @@ from threading import Event
from threading import Event
import types
-from xen.xend import sxp, XendRoot
+from xen.xend import sxp, XendOptions
from xen.xend.XendError import VmError
from xen.xend.XendLogging import log
@@ -50,7 +50,7 @@ xenbusState = {
''Closed'' : 6,
}
-xroot = XendRoot.instance()
+xoptions = XendOptions.instance()
xenbusState.update(dict(zip(xenbusState.values(), xenbusState.keys())))
@@ -324,7 +324,7 @@ class DevController:
Make sure that the migration has finished and only
then return from the call.
"""
- tool = xroot.get_external_migration_tool()
+ tool = xoptions.get_external_migration_tool()
if tool:
log.info("Calling external migration tool for step %d" %
step)
fd = os.popen("%s -type %s -step %d -host %s -domname %s"
%
@@ -341,7 +341,7 @@ class DevController:
""" Recover from device migration. The given step was
the
last one that was successfully executed.
"""
- tool = xroot.get_external_migration_tool()
+ tool = xoptions.get_external_migration_tool()
if tool:
log.info("Calling external migration tool")
fd = os.popen("%s -type %s -step %d -host %s -domname %s
-recover" %
diff --git a/tools/python/xen/xend/server/SrvRoot.py
b/tools/python/xen/xend/server/SrvRoot.py
--- a/tools/python/xen/xend/server/SrvRoot.py
+++ b/tools/python/xen/xend/server/SrvRoot.py
@@ -25,7 +25,7 @@ class SrvRoot(SrvDir):
"""Server sub-components. Each entry is (name, class), where
''name'' is the entry name and ''class''
is the name of its class.
"""
- #todo Get this list from the XendRoot config.
+ #todo Get this list from the XendOptions config.
subdirs = [
(''node'', ''SrvNode'' ),
(''domain'', ''SrvDomainDir'' ),
diff --git a/tools/python/xen/xend/server/SrvServer.py
b/tools/python/xen/xend/server/SrvServer.py
--- a/tools/python/xen/xend/server/SrvServer.py
+++ b/tools/python/xen/xend/server/SrvServer.py
@@ -48,7 +48,7 @@ from threading import Thread
from xen.web.httpserver import HttpServer, UnixHttpServer
-from xen.xend import XendNode, XendRoot, XendAPI
+from xen.xend import XendNode, XendOptions, XendAPI
from xen.xend import Vifctl
from xen.xend.XendLogging import log
from xen.xend.XendClient import XEN_API_SOCKET
@@ -57,7 +57,7 @@ from SrvRoot import SrvRoot
from SrvRoot import SrvRoot
from XMLRPCServer import XMLRPCServer
-xroot = XendRoot.instance()
+xoptions = XendOptions.instance()
class XendServers:
@@ -165,7 +165,7 @@ class XendServers:
log.info("Restarting all XML-RPC and Xen-API
servers...")
self.cleaningUp = False
self.reloadingConfig = False
- xroot.set_config()
+ xoptions.set_config()
new_servers = [x for x in self.servers
if isinstance(x, HttpServer)]
self.servers = new_servers
@@ -174,16 +174,16 @@ class XendServers:
break
def _loadConfig(servers, root, reload):
- if not reload and xroot.get_xend_http_server():
+ if not reload and xoptions.get_xend_http_server():
servers.add(HttpServer(root,
- xroot.get_xend_address(),
- xroot.get_xend_port()))
- if not reload and xroot.get_xend_unix_server():
- path = xroot.get_xend_unix_path()
+ xoptions.get_xend_address(),
+ xoptions.get_xend_port()))
+ if not reload and xoptions.get_xend_unix_server():
+ path = xoptions.get_xend_unix_path()
log.info(''unix path='' + path)
servers.add(UnixHttpServer(root, path))
- api_cfg = xroot.get_xen_api_server()
+ api_cfg = xoptions.get_xen_api_server()
if api_cfg:
try:
addrs = [(str(x[0]).split('':''),
@@ -218,10 +218,10 @@ def _loadConfig(servers, root, reload):
except TypeError, exn:
log.error(''Xen-API server configuration %s is
invalid.'', api_cfg)
- if xroot.get_xend_tcp_xmlrpc_server():
+ if xoptions.get_xend_tcp_xmlrpc_server():
servers.add(XMLRPCServer(XendAPI.AUTH_PAM, False, True))
- if xroot.get_xend_unix_xmlrpc_server():
+ if xoptions.get_xend_unix_xmlrpc_server():
servers.add(XMLRPCServer(XendAPI.AUTH_PAM, False))
diff --git a/tools/python/xen/xend/server/netif.py
b/tools/python/xen/xend/server/netif.py
--- a/tools/python/xen/xend/server/netif.py
+++ b/tools/python/xen/xend/server/netif.py
@@ -24,10 +24,10 @@ import random
import random
import re
-from xen.xend import XendRoot
+from xen.xend import XendOptions
from xen.xend.server.DevController import DevController
-xroot = XendRoot.instance()
+xoptions = XendOptions.instance()
def randomMAC():
"""Generate a random MAC address.
@@ -138,8 +138,8 @@ class NetifController(DevController):
def getDeviceDetails(self, config):
"""@see DevController.getDeviceDetails"""
- script = os.path.join(xroot.network_script_dir,
- config.get(''script'',
xroot.get_vif_script()))
+ script = os.path.join(xoptions.network_script_dir,
+ config.get(''script'',
xoptions.get_vif_script()))
typ = config.get(''type'')
bridge = config.get(''bridge'')
mac = config.get(''mac'')
@@ -190,7 +190,7 @@ class NetifController(DevController):
(script, ip, bridge, mac, typ, vifname, rate, uuid) = devinfo
if script:
- network_script_dir = xroot.network_script_dir + os.sep
+ network_script_dir = xoptions.network_script_dir + os.sep
result[''script''] =
script.replace(network_script_dir, "")
if ip:
result[''ip''] = ip
diff --git a/tools/python/xen/xend/server/relocate.py
b/tools/python/xen/xend/server/relocate.py
--- a/tools/python/xen/xend/server/relocate.py
+++ b/tools/python/xen/xend/server/relocate.py
@@ -24,7 +24,7 @@ from xen.web import protocol, tcp, unix
from xen.xend import sxp
from xen.xend import XendDomain
-from xen.xend import XendRoot
+from xen.xend import XendOptions
from xen.xend.XendError import XendError
from xen.xend.XendLogging import log
@@ -114,15 +114,15 @@ class RelocationProtocol(protocol.Protoc
def listenRelocation():
- xroot = XendRoot.instance()
- if xroot.get_xend_unix_server():
+ xoptions = XendOptions.instance()
+ if xoptions.get_xend_unix_server():
path = ''/var/lib/xend/relocation-socket''
unix.UnixListener(path, RelocationProtocol)
- if xroot.get_xend_relocation_server():
- port = xroot.get_xend_relocation_port()
- interface = xroot.get_xend_relocation_address()
+ if xoptions.get_xend_relocation_server():
+ port = xoptions.get_xend_relocation_port()
+ interface = xoptions.get_xend_relocation_address()
- hosts_allow = xroot.get_xend_relocation_hosts_allow()
+ hosts_allow = xoptions.get_xend_relocation_hosts_allow()
if hosts_allow == '''':
hosts_allow = None
else:
diff --git a/tools/python/xen/xend/server/tests/test_controllers.py
b/tools/python/xen/xend/server/tests/test_controllers.py
--- a/tools/python/xen/xend/server/tests/test_controllers.py
+++ b/tools/python/xen/xend/server/tests/test_controllers.py
@@ -2,9 +2,9 @@ import re
import re
import unittest
-import xen.xend.XendRoot
+import xen.xend.XendOptions
-xen.xend.XendRoot.XendRoot.config_default = ''/dev/null''
+xen.xend.XendOptions.XendOptions.config_default = ''/dev/null''
from xen.xend.server import netif
@@ -13,7 +13,7 @@ FAKE_DEVID = 63
FAKE_DEVID = 63
-xroot = xen.xend.XendRoot.instance()
+xoptions = xen.xend.XendOptions.instance()
class test_controllers(unittest.TestCase):
@@ -36,8 +36,8 @@ class test_controllers(unittest.TestCase
self.assertEqual(backdets[''handle''], str(FAKE_DEVID))
self.assertEqual(backdets[''script''],
- os.path.join(xroot.network_script_dir,
- xroot.get_vif_script()))
+ os.path.join(xoptions.network_script_dir,
+ xoptions.get_vif_script()))
self.assertValidMac(backdets[''mac''], expectedMac)
self.assertEqual(frontdets[''handle''],
str(FAKE_DEVID))
diff --git a/tools/python/xen/xend/server/tpmif.py
b/tools/python/xen/xend/server/tpmif.py
--- a/tools/python/xen/xend/server/tpmif.py
+++ b/tools/python/xen/xend/server/tpmif.py
@@ -20,7 +20,7 @@
"""Support for virtual TPM interfaces."""
-from xen.xend import XendRoot
+from xen.xend import XendOptions
from xen.xend.XendLogging import log
from xen.xend.XendError import XendError
from xen.xend.XendConstants import DEV_MIGRATE_TEST, VTPM_DELETE_SCRIPT
@@ -29,7 +29,7 @@ import os
import os
import re
-xroot = XendRoot.instance()
+xoptions = XendOptions.instance()
def destroy_vtpmstate(name):
if os.path.exists(VTPM_DELETE_SCRIPT):
@@ -88,7 +88,7 @@ class TPMifController(DevController):
def migrate(self, deviceConfig, network, dst, step, domName):
"""@see DevContoller.migrate"""
if network:
- tool = xroot.get_external_migration_tool()
+ tool = xoptions.get_external_migration_tool()
if tool != '''':
log.info("Request to network-migrate device to %s.
step=%d.",
dst, step)
@@ -116,7 +116,7 @@ class TPMifController(DevController):
def recover_migrate(self, deviceConfig, network, dst, step, domName):
"""@see DevContoller.recover_migrate"""
if network:
- tool = xroot.get_external_migration_tool()
+ tool = xoptions.get_external_migration_tool()
if tool != '''':
log.info("Request to recover network-migrated device. last
good step=%d.",
step)
diff --git a/tools/python/xen/xend/server/vfbif.py
b/tools/python/xen/xend/server/vfbif.py
--- a/tools/python/xen/xend/server/vfbif.py
+++ b/tools/python/xen/xend/server/vfbif.py
@@ -52,7 +52,7 @@ class VfbifController(DevController):
if config.has_key("vncpasswd"):
passwd = config["vncpasswd"]
else:
- passwd = xen.xend.XendRoot.instance().get_vncpasswd_default()
+ passwd =
xen.xend.XendOptions.instance().get_vncpasswd_default()
if passwd:
self.vm.storeVm("vncpasswd", passwd)
log.debug("Stored a VNC password for vfb access")
@@ -66,7 +66,7 @@ class VfbifController(DevController):
elif config.has_key("vncdisplay"):
args += ["--vncport", "%d" % (5900 +
int(config["vncdisplay"]))]
vnclisten = config.get("vnclisten",
-
xen.xend.XendRoot.instance().get_vnclisten_address())
+
xen.xend.XendOptions.instance().get_vnclisten_address())
args += [ "--listen", vnclisten ]
spawn_detached(args[0], args + std_args, os.environ)
elif t == "sdl":
diff --git a/tools/python/xen/xm/tests/test_create.py
b/tools/python/xen/xm/tests/test_create.py
--- a/tools/python/xen/xm/tests/test_create.py
+++ b/tools/python/xen/xm/tests/test_create.py
@@ -3,9 +3,9 @@ import tempfile
import tempfile
import unittest
-import xen.xend.XendRoot
-
-xen.xend.XendRoot.XendRoot.config_default = ''/dev/null''
+import xen.xend.XendOptions
+
+xen.xend.XendOptions.XendOptions.config_default = ''/dev/null''
import xen.xm.create
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
On Tue, Jan 16, 2007 at 07:43:08PM -0700, John Levon wrote:> # HG changeset patch > # User john.levon@sun.com > # Date 1169005385 28800 > # Node ID 3a35936342d6a1f8ebd24a54da2461b33d811496 > # Parent 48b7dd3a28d7ea8fa26ea54eb337606f93433dc5 > Rename XendRoot to XendOptions. > > Signed-off-by: John Levon <john.levon@sun.com> > > diff --git a/tools/python/xen/xend/Vifctl.py b/tools/python/xen/xend/Vifctl.pyApplied. This patch actually just renamed XendRoot -> XendOptions, rather than updating all of the self-references therein, but I got what you meant. Sorry for the delay -- I thought Keir had picked this one up first time around, but obviously not. Ewan. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Thu, Jan 18, 2007 at 03:15:33PM +0000, Ewan Mellor wrote:> Applied. This patch actually just renamed XendRoot -> XendOptions, rather > than updating all of the self-references therein, but I got what you meant.Did it not apply properly? The patch has: rename from tools/python/xen/xend/XendRoot.py rename to tools/python/xen/xend/XendOptions.py --- a/tools/python/xen/xend/XendOptions.py +++ b/tools/python/xen/xend/XendOptions.py @@ -16,11 +16,11 @@ # Copyright (C) 2005 XenSource Ltd #=========================================================================== -"""Xend root class. -Creates the servers and handles configuration. +"""Xend options. +Handles configuration. etc. Maybe hg doesn''t automatically grok git patches unless you enable the option? If so, my apologies. regards john _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Thu, Jan 18, 2007 at 03:21:23PM +0000, John Levon wrote:> On Thu, Jan 18, 2007 at 03:15:33PM +0000, Ewan Mellor wrote: > > > Applied. This patch actually just renamed XendRoot -> XendOptions, rather > > than updating all of the self-references therein, but I got what you meant. > > Did it not apply properly? The patch has: > > rename from tools/python/xen/xend/XendRoot.py > rename to tools/python/xen/xend/XendOptions.py > --- a/tools/python/xen/xend/XendOptions.py > +++ b/tools/python/xen/xend/XendOptions.py > @@ -16,11 +16,11 @@ > # Copyright (C) 2005 XenSource Ltd > #===========================================================================> > -"""Xend root class. > -Creates the servers and handles configuration. > +"""Xend options. > +Handles configuration. > > etc. > > Maybe hg doesn''t automatically grok git patches unless you enable the option? > If so, my apologies.Mine didn''t grok the rename line, and I missed the fact that you''d updated it afterwards (that''s cute, I wish it worked ;-) Ewan. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Thu, Jan 18, 2007 at 03:49:09PM +0000, Ewan Mellor wrote:> Mine didn''t grok the rename line, and I missed the fact that you''d updated it > afterwards (that''s cute, I wish it worked ;-)I have: [diff] git=True in my .hgrc. I don''t know if that''s sufficient for hg import to work properly. I''ll make sure to avoid this next time. thanks, john _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Thu, Jan 18, 2007 at 03:54:33PM +0000, John Levon wrote:> On Thu, Jan 18, 2007 at 03:49:09PM +0000, Ewan Mellor wrote: > > > Mine didn''t grok the rename line, and I missed the fact that you''d updated it > > afterwards (that''s cute, I wish it worked ;-) > > I have: > > [diff] > git=True > > in my .hgrc. I don''t know if that''s sufficient for hg import to work > properly. I''ll make sure to avoid this next time.hg 0.9.2''s changelog says: support for git-style extended patches with --git option (I''m using 0.9.1). Ewan. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel