The patch is against xen-unstable 13205:886f7312257e, but should also apply to 3.0.4. Signed-off-by: John Byrne <john.l.byrne@hp.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2007-Jan-03 08:12 UTC
Re: [Xen-devel] [PATCH] Allow blktap to build as a module
I had posted a patch for this quite a while back (no clue why it wasn''t picked up), though allowing the module to be more logically named blktap.ko. I''d really dislike to now have a blktp.ko. Jan>>> John Byrne <john.l.byrne@hp.com> 03.01.07 01:58 >>>The patch is against xen-unstable 13205:886f7312257e, but should also apply to 3.0.4. Signed-off-by: John Byrne <john.l.byrne@hp.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2007-Jan-03 08:20 UTC
Re: [Xen-devel] [PATCH] Allow blktap to build as a module
IIRC blktap doesn''t straightforwardly build and work as a module. Some code cleanup is required (getting rid of zap_page_range()?). There''s no point in taking the trivial Makefile fragment until that is fixed satisfactorily. -- Keir On 3/1/07 8:12 am, "Jan Beulich" <jbeulich@novell.com> wrote:> I had posted a patch for this quite a while back (no clue why it wasn''t picked > up), > though allowing the module to be more logically named blktap.ko. I''d really > dislike to > now have a blktp.ko. Jan > >>>> John Byrne <john.l.byrne@hp.com> 03.01.07 01:58 >>> > > The patch is against xen-unstable 13205:886f7312257e, but should also > apply to 3.0.4. > > Signed-off-by: John Byrne <john.l.byrne@hp.com> > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2007-Jan-03 08:41 UTC
Re: [Xen-devel] [PATCH] Allow blktap to build as a module
>>> Keir Fraser <Keir.Fraser@cl.cam.ac.uk> 03.01.07 09:20 >>> >IIRC blktap doesn''t straightforwardly build and work as a module. Some code >cleanup is required (getting rid of zap_page_range()?). There''s no point in >taking the trivial Makefile fragment until that is fixed satisfactorily.For the moment, we just leveraged the fact that in the SLE10 kernels zap_page_range() is being exported for other reasons. In 10.2, we added the export. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Daniel P. Berrange
2007-Jan-03 12:45 UTC
Re: [Xen-devel] [PATCH] Allow blktap to build as a module
On Wed, Jan 03, 2007 at 08:41:10AM +0000, Jan Beulich wrote:> >>> Keir Fraser <Keir.Fraser@cl.cam.ac.uk> 03.01.07 09:20 >>> > >IIRC blktap doesn''t straightforwardly build and work as a module. Some code > >cleanup is required (getting rid of zap_page_range()?). There''s no point in > >taking the trivial Makefile fragment until that is fixed satisfactorily. > > For the moment, we just leveraged the fact that in the SLE10 kernels > zap_page_range() is being exported for other reasons. In 10.2, we added > the export.We did likewise for Fedora & RHEL - it was pretty trivial really to make it work as a module. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
John Byrne
2007-Jan-03 18:15 UTC
Re: [Xen-devel] [PATCH] Allow blktap to build as a module
Keir Fraser wrote:> IIRC blktap doesn''t straightforwardly build and work as a module. Some code > cleanup is required (getting rid of zap_page_range()?). There''s no point in > taking the trivial Makefile fragment until that is fixed satisfactorily. > > -- KeirI thought I''d tested it. (You had me worried) zap_page_range() got exported in 12678:260426e3924f as part of the virtual frame buffer patch. If Jan has a patch that doesn''t change the name, that would be better. I didn''t much like the name change, but I was being lazy. John> > On 3/1/07 8:12 am, "Jan Beulich" <jbeulich@novell.com> wrote: > >> I had posted a patch for this quite a while back (no clue why it wasn''t picked >> up), >> though allowing the module to be more logically named blktap.ko. I''d really >> dislike to >> now have a blktp.ko. Jan >> >>>>> John Byrne <john.l.byrne@hp.com> 03.01.07 01:58 >>> >> The patch is against xen-unstable 13205:886f7312257e, but should also >> apply to 3.0.4. >> >> Signed-off-by: John Byrne <john.l.byrne@hp.com> >> >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel > > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel