John Levon
2006-Dec-28 17:40 UTC
[Xen-devel] [PATCH] Allow arbitrary values for the vif ''type''.
# HG changeset patch
# User john.levon@sun.com
# Date 1167320483 28800
# Node ID 40b0d73d9789e99d71ad5b46ee85faf85e09c21f
# Parent 48c66819eb6aa4512d984eee37d0e5afda928035
Allow arbitrary values for the vif ''type''.
Signed-off-by: David Edmondson <dme@sun.com>
diff --git a/tools/python/xen/xend/server/netif.py
b/tools/python/xen/xend/server/netif.py
--- a/tools/python/xen/xend/server/netif.py
+++ b/tools/python/xen/xend/server/netif.py
@@ -150,16 +150,20 @@ class NetifController(DevController):
devid = self.allocateDeviceID()
+ # The default type is ''netfront''.
+ if not typ:
+ typ = ''netfront''
+
if not mac:
mac = randomMAC()
back = { ''script'' : script,
''mac'' : mac,
- ''handle'' : "%i" % devid }
+ ''handle'' : "%i" % devid,
+ ''type'' : typ }
if typ == ''ioemu'':
front = {}
- back[''type''] = ''ioemu''
else:
front = { ''handle'' : "%i" % devid,
''mac'' : mac }
diff --git a/tools/python/xen/xm/create.py b/tools/python/xen/xm/create.py
--- a/tools/python/xen/xm/create.py
+++ b/tools/python/xen/xm/create.py
@@ -300,7 +300,7 @@ gopts.var(''vif'',
val="type=TYPE,mac=MAC,
fn=append_value, default=[],
use="""Add a network interface with the given MAC
address and bridge.
The vif is configured by calling the given configuration script.
- If type is not specified, default is netfront not ioemu device.
+ If type is not specified, default is netfront.
If mac is not specified a random MAC address is used.
If not specified then the network backend chooses it''s own
MAC address.
If bridge is not specified the first bridge found is used.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
John Levon
2007-Jan-04 15:47 UTC
Re: [Xen-devel] [PATCH] Allow arbitrary values for the vif ''type''.
On Thu, Dec 28, 2006 at 05:40:52PM +0000, John Levon wrote:> # HG changeset patch > # User john.levon@sun.com > # Date 1167320483 28800 > # Node ID 40b0d73d9789e99d71ad5b46ee85faf85e09c21f > # Parent 48c66819eb6aa4512d984eee37d0e5afda928035 > Allow arbitrary values for the vif ''type''.We need this change to support the way we''re doing certain types of netif backends. Could somebody have a look? thanks john _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2007-Jan-04 15:59 UTC
Re: [Xen-devel] [PATCH] Allow arbitrary values for the vif ''type''.
>> # HG changeset patch >> # User john.levon@sun.com >> # Date 1167320483 28800 >> # Node ID 40b0d73d9789e99d71ad5b46ee85faf85e09c21f >> # Parent 48c66819eb6aa4512d984eee37d0e5afda928035 >> Allow arbitrary values for the vif ''type''. > > We need this change to support the way we''re doing certain types of > netif backends. Could somebody have a look?Applied now. K. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel