Fix the grammar in the comment that features in
xen_machine_kexec_setup_resources(). The current
edition is a bit odd.
Signed-off-by: Simon Horman <horms@verge.net.au>
diff -r a9a43705f26b linux-2.6-xen-sparse/drivers/xen/core/machine_kexec.c
--- a/linux-2.6-xen-sparse/drivers/xen/core/machine_kexec.c Wed Dec 27 00:38:01
2006 +0000
+++ b/linux-2.6-xen-sparse/drivers/xen/core/machine_kexec.c Wed Dec 27 13:21:54
2006 +0900
@@ -99,7 +99,7 @@ void xen_machine_kexec_setup_resources(v
/*
* It isn''t possible to free xen_phys_cpus this early in the
* boot. Since failure at this stage is unexpected and the
- * amount is small we leak the memory.
+ * amount of memory that we leak is small.
*/
xen_max_nr_phys_cpus = 0;
return;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Hi, I am resending this patch, please consider.
--
Horms
Fix the grammar in the comment that features in
xen_machine_kexec_setup_resources(). The current
edition is a bit odd.
Signed-off-by: Simon Horman <horms@verge.net.au>
diff -r a9a43705f26b linux-2.6-xen-sparse/drivers/xen/core/machine_kexec.c
--- a/linux-2.6-xen-sparse/drivers/xen/core/machine_kexec.c Wed Dec 27 00:38:01
2006 +0000
+++ b/linux-2.6-xen-sparse/drivers/xen/core/machine_kexec.c Wed Dec 27 13:21:54
2006 +0900
@@ -99,7 +99,7 @@ void xen_machine_kexec_setup_resources(v
/*
* It isn''t possible to free xen_phys_cpus this early in the
* boot. Since failure at this stage is unexpected and the
- * amount is small we leak the memory.
+ * amount of memory that we leak is small.
*/
xen_max_nr_phys_cpus = 0;
return;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Ian Campbell
2007-Jan-10 09:29 UTC
[Xen-devel] Re: [PATCH] kexec/kdump: fix grammar in comment
On Wed, 2007-01-10 at 17:03 +0900, Horms wrote:> Fix the grammar in the comment that features in > xen_machine_kexec_setup_resources(). The current > edition is a bit odd.What I was trying to say is that we allow a possible memory leak because the failure is unexpected and the amount is small, your version doesn''t really convey that information. I''ve changed it to: * It isn''t possible to free xen_phys_cpus this early in the * boot. Failure at this stage is unexpected and the * amount of memory is small therefore we tolerate the * potential leak. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2007-Jan-10 10:39 UTC
Re: [Xen-devel] [PATCH] kexec/kdump: fix grammar in comment
The existing sentence is grammatically okay and fits better with the first sentence. K. On 10/1/07 08:03, "Horms" <horms@verge.net.au> wrote:> Hi, I am resending this patch, please consider._______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Wed, Jan 10, 2007 at 09:29:18AM +0000, Ian Campbell wrote:> On Wed, 2007-01-10 at 17:03 +0900, Horms wrote: > > Fix the grammar in the comment that features in > > xen_machine_kexec_setup_resources(). The current > > edition is a bit odd. > > What I was trying to say is that we allow a possible memory leak because > the failure is unexpected and the amount is small, your version doesn''t > really convey that information. > > I''ve changed it to: > > * It isn''t possible to free xen_phys_cpus this early in the > * boot. Failure at this stage is unexpected and the > * amount of memory is small therefore we tolerate the > * potential leak.Thanks. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel