Jim Fehlig
2006-Nov-17 23:34 UTC
[Xen-devel] [PATCH] [xend] Fix on-wire response for RPCs that return void
The legacy apis return a value of None on success, which was being converted to an illegal (as per Xen API spec) value of ''nil'' in the xmlrpc response. An example of the invalid on-wire response: <methodResponse> <params> <param> <value> <struct> <member> <name>Status</name> <value><string>Success</string></value> </member> <member> <name>Value</name> <value><nil/></value> </member> </struct> </value> </param> </params> </methodResponse> The Xen IPI spec states that destroy, hard_shutdown, pause, resume, start, suspend, and unpause return void. This patch makes it so and permits proper parsing of the response by clients (libxen) that follow the spec. Jim _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ewan Mellor
2006-Nov-22 14:10 UTC
Re: [Xen-devel] [PATCH] [xend] Fix on-wire response for RPCs that return void
On Fri, Nov 17, 2006 at 04:34:41PM -0700, Jim Fehlig wrote:> # HG changeset patch > # User jfehlig@jfehlig2.provo.novell.com > # Date 1163805674 25200 > # Node ID 5d168b8e743a432ba719dbb990e77164c58b080d > # Parent f0ba459065d32b61c9d04ccde5787e48e23be782 > The legacy apis return a value of None on success, which was being converted to a value of ''nil'' in the xmlrpc response. > The Xen IPI spec states that destroy, hard_shutdown, pause, resume, start, suspend, and unpause return void. This patch makes it so and permits proper parsing of the response by clients (libxen) that follow the spec. > > Signed-off-by: Jim Fehlig <jfehlig@novell.com>Applied, thanks Jim. Ewan. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel