HVM cleanups: 1) make vmx/svm time functions hvm common, since they are acturally the same. 2) move hvm_send_assist_req from platform.c to hvm.c. 2) rename VMX MSR context switch functions to make them more readable. 3) misc coding style clean ups. Signed-off-by: Xin Li <xin.b.li@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Rebased to staging tip. -Xin>-----Original Message----- >From: xen-devel-bounces@lists.xensource.com >[mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of Li, Xin B >Sent: 2006年11月17日 1:05 >To: xen-devel@lists.xensource.com >Subject: [Xen-devel] [PATCH] HVM cleanups > >HVM cleanups: >1) make vmx/svm time functions hvm common, since they are acturally the >same. >2) move hvm_send_assist_req from platform.c to hvm.c. >2) rename VMX MSR context switch functions to make them more readable. >3) misc coding style clean ups. > >Signed-off-by: Xin Li <xin.b.li@intel.com> >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir, now in xen/arch/x86/hvm directory we have hvm.c, platform.c, io.c, intercept.c; I think these some of these file names are not clear, sometimes I don''t remember which file a hvm function lives in :-(, maybe it''s time to clean them, for example maybe it''s better to name platform.c as mmio.c, and some functions need to be moved from one file to another, also we can merge some files. -Xin>-----Original Message----- >From: Li, Xin B >Sent: 2006年11月17日 2:09 >To: Li, Xin B; xen-devel@lists.xensource.com >Subject: RE: [Xen-devel] [PATCH] HVM cleanups > >Rebased to staging tip. >-Xin > >>-----Original Message----- >>From: xen-devel-bounces@lists.xensource.com >>[mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of Li, Xin B >>Sent: 2006年11月17日 1:05 >>To: xen-devel@lists.xensource.com >>Subject: [Xen-devel] [PATCH] HVM cleanups >> >>HVM cleanups: >>1) make vmx/svm time functions hvm common, since they are >acturally the >>same. >>2) move hvm_send_assist_req from platform.c to hvm.c. >>2) rename VMX MSR context switch functions to make them more readable. >>3) misc coding style clean ups. >> >>Signed-off-by: Xin Li <xin.b.li@intel.com> >> >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 17/11/06 8:12 am, "Li, Xin B" <xin.b.li@intel.com> wrote:> now in xen/arch/x86/hvm directory we have hvm.c, platform.c, io.c, > intercept.c; I think these some of these file names are not clear, sometimes I > don''t remember which file a hvm function lives in :-(, maybe it''s time to > clean them, for example maybe it''s better to name platform.c as mmio.c, and > some functions need to be moved from one file to another, also we can merge > some files.I agree that this needs cleaning up at some point, as control flow seems to jump randomly across these files. But I live in hope that the MMIO decoder will die at some point soon and that should kill off much of io.c and platform.c anyway. What about all the other stuff? Do you have a plan already about: (a) what subsystems/functions we have to support; and (b) what filenames you think they belong in? Renames are a pain for some people so I''d like any rename to happen only once. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel