Xen devel - Nov 2006 - [Patch] for expanding the vbd devices

Hi all.

I send the following message and patch about two weeks ago.
But there is no response.

Is there any problem or no ?

Please let me know.


Thank you,                                           Nishi





-----------------------転送元のメール-----------------------
From:     Hidetoshi Nishi <nishi.hidetoshi@jp.fujitsu.com>
To:       xen-devel@lists.xensource.com
Subject:  [Xen-devel] Patch for expanding the vbd devices


Hi all.

My name is Hidetoshi Nishi, work for FUJITSU.

I make a patch for expanding the vbd devices up to 256.

And I tested the patch, I have following problem.

If the guest''s kernel has SCSI driver already, guest''s kernel
gets major
number when guest is initialized, even though guest config file not 
includes sdx device.
And after guest is initialied, I try to attach vbd using block-attach as 
sdx, attached vbd can''t get major number of SCSI, because SCSI driver 
get the major number already. Then I can''t attach vbd.

Accordingly I made SCSI driver to be moduled, and I tried to test the 
patch.

I try to increse vbd devices up to 120, and it seems be O.K.


Best regards,                                       Nishi



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Hi all.

Thank you for applying the patch.

I have one question.

The patch I sent includes extending the timer of device creation.
But this change is not merged, it has some problem.

If you have some comment, please let me know.


Thanks a lot,                                    Nishi

----------------------------------------------------------------
--- a/tools/python/xen/xend/server/DevController.py	Thu Oct 26 18:
03:43 2006 +0900
+++ b/tools/python/xen/xend/server/DevController.py	Thu Oct 26 18:
22:09 2006 +0900
@@ -25,7 +25,7 @@ from xen.xend.xenstore.xstransact import
 from xen.xend.xenstore.xstransact import xstransact, complete
 from xen.xend.xenstore.xswatch import xswatch
 
-DEVICE_CREATE_TIMEOUT = 100
+DEVICE_CREATE_TIMEOUT = 600
 HOTPLUG_STATUS_NODE = "hotplug-status"
 HOTPLUG_ERROR_NODE  = "hotplug-error"
 HOTPLUG_STATUS_ERROR = "error"

-------------------------------------------------------------------
>From:     Hidetoshi Nishi <nishi.hidetoshi@jp.fujitsu.com>
>To:       xen-devel@lists.xensource.com
>Subject:  [Xen-devel] Patch for expanding the vbd devices
>
>
>Hi all.
>
>My name is Hidetoshi Nishi, work for FUJITSU.
>
>I make a patch for expanding the vbd devices up to 256.
>
>And I tested the patch, I have following problem.
>
>If the guest''s kernel has SCSI driver already, guest''s
kernel gets major
>number when guest is initialized, even though guest config file not 
>includes sdx device.
>And after guest is initialied, I try to attach vbd using block-attach as 
>sdx, attached vbd can''t get major number of SCSI, because SCSI
driver
>get the major number already. Then I can''t attach vbd.
>
>Accordingly I made SCSI driver to be moduled, and I tried to test the 
>patch.
>
>I try to increse vbd devices up to 120, and it seems be O.K.
>
>
>Best regards,                                       Nishi
>
>
>
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@lists.xensource.com
>http://lists.xensource.com/xen-devel
>
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@lists.xensource.com
>http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 10/11/06 12:26, "Hidetoshi Nishi"
<nishi.hidetoshi@jp.fujitsu.com> wrote:
> The patch I sent includes extending the timer of device creation.
> But this change is not merged, it has some problem.
One and a half minutes is really long enough to wait. Most users will assume
a problem has occurred well before that.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

　Hi Keir,
　
　I think the extending the timer of device creation is needed for        
  expanding the vbd devices.
　Because I tested the patch upto 120 device, I had that the domain
　could not create caused by the timer of domain create expired.
　Then we need the change of extending the timer.
  
  And I think it is better to add the logic of displaying the 
  progress of domain creating like as sand clock, because user 
  confuse that the sequence of creating is working or not.
  But I have no action about this.
  
  
  
  
  Thank you                                          Nishi
　
>
>
>
>On 10/11/06 12:26, "Hidetoshi Nishi"
<nishi.hidetoshi@jp.fujitsu.com> wrote:
>
>> The patch I sent includes extending the timer of device creation.
>> But this change is not merged, it has some problem.
>
>One and a half minutes is really long enough to wait. Most users will assume
>a problem has occurred well before that.
>
> -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 13/11/06 5:35 am, "Hidetoshi Nishi"
<nishi.hidetoshi@jp.fujitsu.com>
wrote:
> 　I think the extending the timer of device creation is needed for
>   expanding the vbd devices.
> 　Because I tested the patch upto 120 device, I had that the domain
> 　could not create caused by the timer of domain create expired.
> 　Then we need the change of extending the timer.
>   
>   And I think it is better to add the logic of displaying the
>   progress of domain creating like as sand clock, because user
>   confuse that the sequence of creating is working or not.
>   But I have no action about this.
Without something like that no user is going to wait 10 minutes for a domain
to be created. So extending the timeout that far is quite pointless.

It would be interesting to know *why* it takes 10 minutes to set up 120
backend devices. I know there are quite a few steps involved but that is
very slow. Perhaps someone could profile the system?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

　Hi Keir-san,
　
　I''m very sorry to be late for the response.
　
　I think we have still porblem for user wish to use many disks.
　As you say, "there are quite a few steps involved but that is
  very slow", I think so too. But Time-Out occurs to create Domain
  is more important problem.
  
  I think we have two way to fix time-out problem quickly.
  - extend the timer value
  - be able to set timer value with config file according to number of 
    disks
    
  Please let me know about these.
  
  Thank you                                      Nishi
>On 13/11/06 5:35 am, "Hidetoshi Nishi"
<nishi.hidetoshi@jp.fujitsu.com>
>wrote:
>
>> 　I think the extending the timer of device creation is needed for
>>   expanding the vbd devices.
>> 　Because I tested the patch upto 120 device, I had that the domain
>> 　could not create caused by the timer of domain create expired.
>> 　Then we need the change of extending the timer.
>>   
>>   And I think it is better to add the logic of displaying the
>>   progress of domain creating like as sand clock, because user
>>   confuse that the sequence of creating is working or not.
>>   But I have no action about this.
>
>Without something like that no user is going to wait 10 minutes for a domain
>to be created. So extending the timeout that far is quite pointless.
>
>It would be interesting to know *why* it takes 10 minutes to set up 120
>backend devices. I know there are quite a few steps involved but that is
>very slow. Perhaps someone could profile the system?
>
> -- Keir
>
>
>
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@lists.xensource.com
>http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel