Hi, hvm memory allocation looks buggy in unstable: First it allocates memory using two xc_domain_memory_populate_physmap() calls, explicitly excluding the vga hole, then the (not allocated) vga hole is released via xc_domain_memory_decrease_reservation() ... cheers, Gerd -- Gerd Hoffmann <kraxel@suse.de> http://www.suse.de/~kraxel/julika-dora.jpeg _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Well clearly it works. I''m not sure why though. :-) The decrease_reservation() request ought to fail and hence fail the HVM guest creation. I''ll look into it. -- Keir On 7/11/06 11:34, "Gerd Hoffmann" <kraxel@suse.de> wrote:> Hi, > > hvm memory allocation looks buggy in unstable: First it allocates > memory using two xc_domain_memory_populate_physmap() calls, explicitly > excluding the vga hole, then the (not allocated) vga hole is released > via xc_domain_memory_decrease_reservation() ... > > cheers, > Gerd_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Error handling in xc_domain_{increase,decrease}_reservation() was broken.
With that fixed the HVM builder was indeed broken, so I removed the
unnecessary decrease_reservation() call. This is all fixed in c/s
12273:5a41ea282c.
Thanks,
Keir
On 7/11/06 11:41, "Keir Fraser" <Keir.Fraser@cl.cam.ac.uk>
wrote:
> Well clearly it works. I''m not sure why though. :-) The
> decrease_reservation() request ought to fail and hence fail the HVM guest
> creation. I''ll look into it.
>
> -- Keir
>
> On 7/11/06 11:34, "Gerd Hoffmann" <kraxel@suse.de> wrote:
>
>> Hi,
>>
>> hvm memory allocation looks buggy in unstable: First it allocates
>> memory using two xc_domain_memory_populate_physmap() calls, explicitly
>> excluding the vga hole, then the (not allocated) vga hole is released
>> via xc_domain_memory_decrease_reservation() ...
>>
>> cheers,
>> Gerd
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel