Xen devel - Dec 2005 - [PATCH] symmetricalization of system info command xm info, top, dmesg and log

These xm info, top, dmesg and log requre no parameter.
But log''s error message differs from other 3 command''s error
messages,
when parameter is given.

# xm log 1
Error: ''xm log'' requires 0 argument.

   log                              Print the xend log

Other 3 commands ignore parameter.
I think it might be better symmetricalize.

Signed-off-by: Yoshinori Katase <y_katase@soft.fujitsu.com>

Best Regards,
Yoshinori Katase


diff -r 829517be689f tools/python/xen/xm/main.py
--- a/tools/python/xen/xm/main.py       Fri Dec 23 15:42:46 2005
+++ b/tools/python/xen/xm/main.py       Mon Dec 26 10:16:56 2005
@@ -625,6 +625,8 @@
     server.xend_domain_cpu_sedf_set(dom, *v)

 def xm_info(args):
+    arg_check(args, "info", 0)
+
     from xen.xend.XendClient import server
     info = server.xend_node()

@@ -645,9 +647,12 @@


 def xm_top(args):
+    arg_check(args, "top", 0)
+
     os.execvp(''xentop'', [''xentop''])

 def xm_dmesg(args):
+    arg_check(args, "dmesg", 0)

     gopts = Opts(use="""[-c|--clear]


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Mon, Dec 26, 2005 at 10:41:26AM +0900, Yoshinori Katase wrote:
> These xm info, top, dmesg and log requre no parameter.
> But log''s error message differs from other 3 command''s
error messages,
> when parameter is given.
> 
> # xm log 1
> Error: ''xm log'' requires 0 argument.
> 
>    log                              Print the xend log
> 
> Other 3 commands ignore parameter.
> I think it might be better symmetricalize.
> 
> Signed-off-by: Yoshinori Katase <y_katase@soft.fujitsu.com>
Applied, thank you.

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel