Xen devel - Dec 2005 - Recent xentrace cset is x86-specific

Cset 8435 ("Add support to xenctx for printing stack..") added
print_stack().  This code needs to be ifdef''d because it is
non-portable.  Also the is_kernel_text just before the call
to print_stack uses ctx.user_regs which doesn''t exist on ia64.

Interestingly, just hours before this was checked in, I ran
xentrace on ia64 for the first time (and it worked!)...

Thanks,
Dan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Correction.  Much of xenctx.c needs work to be portable.
The recent change is forcing it to be compiled in the
Makefile.  LIBBIN in xentrace/Makefile needs to be 
defined only for x86 machines.

Thanks,
Dan
> -----Original Message-----
> From: Magenheimer, Dan (HP Labs Fort Collins) 
> Sent: Thursday, December 22, 2005 4:58 PM
> To: Xen Mailing List
> Cc: Ian.Campbell@xensource.com; Magenheimer, Dan (HP Labs 
> Fort Collins)
> Subject: Recent xentrace cset is x86-specific
> 
> Cset 8435 ("Add support to xenctx for printing stack..") added
> print_stack().  This code needs to be ifdef''d because it is
> non-portable.  Also the is_kernel_text just before the call
> to print_stack uses ctx.user_regs which doesn''t exist on ia64.
> 
> Interestingly, just hours before this was checked in, I ran
> xentrace on ia64 for the first time (and it worked!)...
> 
> Thanks,
> Dan
> 
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Thu, 2005-12-22 at 16:08 -0800, Magenheimer, Dan (HP Labs Fort
Collins) wrote:
> Correction.  Much of xenctx.c needs work to be portable.
> The recent change is forcing it to be compiled in the
> Makefile.  LIBBIN in xentrace/Makefile needs to be 
> defined only for x86 machines.
I''ve committed a patch which does this, it should appear in the public
tree after regression testing has passed.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Excellent!  Thanks!

Thanks,
Dan 
> -----Original Message-----
> From: Ian Campbell [mailto:Ian.Campbell@XenSource.com] 
> Sent: Friday, December 23, 2005 2:13 AM
> To: Magenheimer, Dan (HP Labs Fort Collins)
> Cc: Xen Mailing List
> Subject: RE: Recent xentrace cset is x86-specific
> 
> On Thu, 2005-12-22 at 16:08 -0800, Magenheimer, Dan (HP Labs Fort
> Collins) wrote:
> > Correction.  Much of xenctx.c needs work to be portable.
> > The recent change is forcing it to be compiled in the
> > Makefile.  LIBBIN in xentrace/Makefile needs to be 
> > defined only for x86 machines.
> 
> I''ve committed a patch which does this, it should appear in the
public
> tree after regression testing has passed.
> 
> Ian.
> 
> 
> 
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel