Dave Virtual
2005-Dec-15 23:19 UTC
[Xen-devel] [PATCH] make network-bridge work in more environments
The attached patch (against xen-unstable) generalizes the network-bridge (and xen-network-common.sh) script so they work: (a) in non-Gentoo environments missing ifup/down (b) when interpreted by a simple-minded shell (e.g. busybox sh) (c) with kernel-level ip=dhcp (no longer rely on parsing ip params from the kernel cmd line) It should still work in all the old cases. I''ve verified it still works on my FC4-IA32e domain 0, as well as under busybox. Dave _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Pratt
2005-Dec-16 04:42 UTC
RE: [Xen-devel] [PATCH] make network-bridge work in more environments
> Subject: [Xen-devel] [PATCH] make network-bridge work in more > environments > > The attached patch (against xen-unstable) generalizes the > network-bridge (and xen-network-common.sh) script so they work: > (a) in non-Gentoo environments missing ifup/down > (b) when interpreted by a simple-minded shell (e.g. busybox sh) > (c) with kernel-level ip=dhcp (no longer rely on parsing ip > params from the kernel cmd line) > > It should still work in all the old cases. I''ve verified it > still works on my FC4-IA32e domain 0, as well as under busybox.Thanks for the patch, but please can we have a signed-off-by: line Ian _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Dave Virtual
2005-Dec-16 15:52 UTC
Re: [Xen-devel] [PATCH] make network-bridge work in more environments
Here you go. - Dave On 12/15/05, Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk> wrote:> > > Subject: [Xen-devel] [PATCH] make network-bridge work in more > > environments > > > > The attached patch (against xen-unstable) generalizes the > > network-bridge (and xen-network-common.sh) script so they work: > > (a) in non-Gentoo environments missing ifup/down > > (b) when interpreted by a simple-minded shell (e.g. busybox sh) > > (c) with kernel-level ip=dhcp (no longer rely on parsing ip > > params from the kernel cmd line) > > > > It should still work in all the old cases. I''ve verified it > > still works on my FC4-IA32e domain 0, as well as under busybox. > > Thanks for the patch, but please can we have a signed-off-by: line > > Ian >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Pratt
2005-Dec-16 21:08 UTC
RE: [Xen-devel] [PATCH] make network-bridge work in more environments
Dear Mr Virtual, I suspect that Dave Virtual may not be your real name. I can take legal advice on whether I can accept a patch from a source that I suspect may be operating under a pseudonym, but I thought I might contact you to see whether you would be prepared to reveal your true identity in a signed-off-by: line? The OSDL DCO does create extra some extra ''paperwork'', but it''s surely important that we cover our collective arses. As a supporter of the Xen project I''m sure you appreciate that. Thanks, Ian PS: If your name really is Mr Virtual, I apologise profusely. With a name like that you should definitely be working for XenSource Inc. We''re always hiring, so please send us your CV! :-)> -----Original Message----- > From: Dave Virtual [mailto:dave.virtual@gmail.com] > Sent: 16 December 2005 07:52 > To: Ian Pratt > Cc: xen-devel@lists.xensource.com; ian.pratt@cl.cam.ac.uk > Subject: Re: [Xen-devel] [PATCH] make network-bridge work in > more environments > > Here you go. > > - Dave > > > On 12/15/05, Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk> wrote: > > > Subject: [Xen-devel] [PATCH] make network-bridge work in more > > environments > > > > The attached patch (against xen-unstable) generalizes the > > network-bridge (and xen-network-common.sh) script so > they work: > > (a) in non-Gentoo environments missing ifup/down > > (b) when interpreted by a simple-minded shell (e.g. > busybox sh) > > (c) with kernel-level ip=dhcp (no longer rely on parsing ip > > params from the kernel cmd line) > > > > It should still work in all the old cases. I''ve verified it > > still works on my FC4-IA32e domain 0, as well as > under busybox. > > Thanks for the patch, but please can we have a > signed-off-by: line > > Ian > > > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel