Li, Xin B
2005-Dec-03 14:02 UTC
[Xen-devel] [PATCH] VMX domain should call domain_crash_synchronous instead of domain_crash
VMX domain should call domain_crash_synchronous instead of domain_crash. Since domain_crash will return at last, VMX domain should not use it. Signed-off-by: Xin Li <xin.b.li@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2005-Dec-03 16:47 UTC
Re: [Xen-devel] [PATCH] VMX domain should call domain_crash_synchronous instead of domain_crash
On 3 Dec 2005, at 14:02, Li, Xin B wrote:> VMX domain should call domain_crash_synchronous instead of > domain_crash. > Since domain_crash will return at last, VMX domain should not use it.Sometimes delaying the crash is the right thing to do, if you are in a context with locks held (for example). You will still stop executing before returning to guest context. Are you sure that all the changes from domain_crash -> domain_crash_synchronous are correct? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Li, Xin B
2005-Dec-04 04:13 UTC
RE: [Xen-devel] [PATCH] VMX domain should call domain_crash_synchronous instead of domain_crash
>> VMX domain should call domain_crash_synchronous instead of >> domain_crash. >> Since domain_crash will return at last, VMX domain should not use it. > >Sometimes delaying the crash is the right thing to do, if you are in a >context with locks held (for example). You will still stop executing >before returning to guest context. Are you sure that all the changes >from domain_crash -> domain_crash_synchronous are correct? >Yes, they are correct. For vmx domain, return of domain_crash will cause some unexpected code gets executed, which may crashes xen HV. -Xin> -- Keir > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel