Hollis Blanchard
2005-Aug-18 20:34 UTC
[Xen-devel] Re: [Xen-changelog] Don''t free subtype field unconditionally.
On Thursday 18 August 2005 14:42, Xen patchbot -unstable wrote:> # HG changeset patch > # User cl349@firebug.cl.cam.ac.uk > # Node ID 8d69cb2d4a8889780930fff0374559839fb6cdfb > # Parent 2f09b40595eafd845433d1a25366df59eeb4b6b2 > Don''t free subtype field unconditionally. > Signed-off-by: Christian Limpach <Christian.Limpach@cl.cam.ac.uk> > > diff -r 2f09b40595ea -r 8d69cb2d4a88 > linux-2.6-xen-sparse/drivers/xen/xenbus/xenbus_probe.c --- > a/linux-2.6-xen-sparse/drivers/xen/xenbus/xenbus_probe.c Thu Aug 18 > 19:06:51 2005 +++ > b/linux-2.6-xen-sparse/drivers/xen/xenbus/xenbus_probe.c Thu Aug 18 > 19:07:29 2005 @@ -262,7 +262,8 @@ > if (dev) { > struct xenbus_device *xendev = to_xenbus_device(dev); > > - kfree(xendev->subtype); > + if (xendev->subtype) > + kfree(xendev->subtype); > kfree(xendev); > } > }I don''t think this change is necessary. kfree already guards against NULL pointers, and I have seen many patches in exactly the opposite direction (removing pre-kfree tests). -- Hollis Blanchard IBM Linux Technology Center _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Vincent Hanquez
2005-Aug-18 21:00 UTC
Re: [Xen-devel] Re: [Xen-changelog] Don''t free subtype field unconditionally.
On Thu, Aug 18, 2005 at 03:34:08PM -0500, Hollis Blanchard wrote:> I don''t think this change is necessary. kfree already guards against NULL > pointers, and I have seen many patches in exactly the opposite direction > (removing pre-kfree tests).this code was removed few commits later. -- Vincent Hanquez _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel