On 11 Aug 2005, at 22:48, Jerone Young wrote:> In function vmx_dr_access in xen/arch/x86/vmx.c there is a long pointer > named "reg_p". reg_p is assigned to > > v->arch.guest_context.debugreg[reg] = *reg_p; > > in the switch case TYPE_MOV_TO_DR. > > yet it has no assignment before this? What is the intent of reg_p? > > It also is assigned in the switch case TYPE_MOVE_FROM_DR...yet it''s not > used for anything ?It''s assigned to in the macro CASE_GET_REG_P. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
In function vmx_dr_access in xen/arch/x86/vmx.c there is a long pointer named "reg_p". reg_p is assigned to v->arch.guest_context.debugreg[reg] = *reg_p; in the switch case TYPE_MOV_TO_DR. yet it has no assignment before this? What is the intent of reg_p? It also is assigned in the switch case TYPE_MOVE_FROM_DR...yet it''s not used for anything ? -- Jerone Young IBM Linux Technology Center jyoung5@us.ibm.com 512-838-1157 (T/L: 678-1157) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Thu, 2005-08-11 at 22:47 +0100, Keir Fraser wrote:> On 11 Aug 2005, at 22:48, Jerone Young wrote: > > > In function vmx_dr_access in xen/arch/x86/vmx.c there is a long pointer > > named "reg_p". reg_p is assigned to > > > > v->arch.guest_context.debugreg[reg] = *reg_p; > > > > in the switch case TYPE_MOV_TO_DR. > > > > yet it has no assignment before this? What is the intent of reg_p? > > > > It also is assigned in the switch case TYPE_MOVE_FROM_DR...yet it''s not > > used for anything ? > > It''s assigned to in the macro CASE_GET_REG_P.doh! it''s sitting right above the function :-)> > -- Keir > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >-- Jerone Young IBM Linux Technology Center jyoung5@us.ibm.com 512-838-1157 (T/L: 678-1157) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel