Do we have a minimum gnu make vesion? Specifically, I want to know if I can use "Target-specific Variable Values" which I believe is dependent on 3.8x. Example: foo.o: CFLAGS += -DFOO_DEBUG -JX -- "I got an idea, an idea so smart my head would explode if I even began to know what I was talking about." -- Peter Griffin (Family Guy) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 25 Jun 2005, at 17:36, Jimi Xenidis wrote:> Do we have a minimum gnu make vesion? > Specifically, I want to know if I can use "Target-specific Variable > Values" which I believe is dependent on 3.8x. > Example: > foo.o: CFLAGS += -DFOO_DEBUGYeah, we allow those. I think they were added before 3.8x, otherwise we wouldn''t use them (we started using $(eval), which is a 3.8x feature, and had complaints from 3.79 users). -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
>>>>> "KF" == Keir Fraser <Keir.Fraser@cl.cam.ac.uk> writes:KF> On 25 Jun 2005, at 17:36, Jimi Xenidis wrote: >> Example: >> foo.o: CFLAGS += -DFOO_DEBUG KF> Yeah, we allow those. I think they were added before 3.8x, otherwise we KF> wouldn''t use them (we started using $(eval), which is a 3.8x feature, KF> and had complaints from 3.79 users). Ok cool, that means I can remove my custom %.o:%.c commands and just define CFLAGS for the target. would also like to add an $(AFLAGS) to the %.o: %.S rule liek the following diffs. This allows me to further customize some assemble, paritularly to add -Wa,-gdwarf2, as the followign diff shows: --- /tmp/geta14981 2005-06-25 14:05:11.000000000 -0400 +++ Rules.mk 2005-06-25 12:21:57.000000000 -0400 @@ -80,5 +80,5 @@ $(CC) $(CFLAGS) -c $< -o $@ %.o: %.S $(HDRS) Makefile - $(CC) $(CFLAGS) -D__ASSEMBLY__ -c $< -o $@ + $(CC) $(CFLAGS) $(AFLAGS) -D__ASSEMBLY__ -c $< -o $@ -- "I got an idea, an idea so smart my head would explode if I even began to know what I was talking about." -- Peter Griffin (Family Guy) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 6/25/05, Jimi Xenidis <jimix@watson.ibm.com> wrote:> >>>>> "KF" == Keir Fraser <Keir.Fraser@cl.cam.ac.uk> writes: > > KF> On 25 Jun 2005, at 17:36, Jimi Xenidis wrote: > > >> Example: > >> foo.o: CFLAGS += -DFOO_DEBUG > > KF> Yeah, we allow those. I think they were added before 3.8x, otherwise we > KF> wouldn''t use them (we started using $(eval), which is a 3.8x feature, > KF> and had complaints from 3.79 users). > > Ok cool, that means I can remove my custom %.o:%.c commands and just > define CFLAGS for the target. > would also like to add an $(AFLAGS) to the %.o: %.S rule liek the > following diffs. > > This allows me to further customize some assemble, paritularly to add > -Wa,-gdwarf2, as the followign diff shows: > > --- /tmp/geta14981 2005-06-25 14:05:11.000000000 -0400 > +++ Rules.mk 2005-06-25 12:21:57.000000000 -0400 > @@ -80,5 +80,5 @@ > $(CC) $(CFLAGS) -c $< -o $@ > > %.o: %.S $(HDRS) Makefile > - $(CC) $(CFLAGS) -D__ASSEMBLY__ -c $< -o $@ > + $(CC) $(CFLAGS) $(AFLAGS) -D__ASSEMBLY__ -c $< -o $@ >you should always use diff from outside of xen root directory (so patch would be used with -p1 option). otherwise, it is impossible to know where to apply this patch (there are many Rules.mk file in the source tree) regards, aq _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 25 Jun 2005, at 19:07, Jimi Xenidis wrote:> This allows me to further customize some assemble, paritularly to add > -Wa,-gdwarf2, as the followign diff shows:Perfectly fine. K. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
>>>>> "a" == aq <aquynh@gmail.com> writes:>> --- /tmp/geta14981 2005-06-25 14:05:11.000000000 -0400 >> +++ Rules.mk 2005-06-25 12:21:57.000000000 -0400 >> @@ -80,5 +80,5 @@ >> $(CC) $(CFLAGS) -c $< -o $@ >> >> %.o: %.S $(HDRS) Makefile >> - $(CC) $(CFLAGS) -D__ASSEMBLY__ -c $< -o $@ >> + $(CC) $(CFLAGS) $(AFLAGS) -D__ASSEMBLY__ -c $< -o $@ >> a> you should always use diff from outside of xen root directory (so a> patch would be used with -p1 option). The diff was not really intended for patch, but more as an example. -JX -- "I got an idea, an idea so smart my head would explode if I even began to know what I was talking about." -- Peter Griffin (Family Guy) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel