Xen devel - Jun 2005 - [PATCH] Fix vnc-dryrun option interaction

A patch that was applied yesterday tried to turn the vnc option off if 
dryrun was set.  Unfortunately, the way it was actually coded turned 
vnc ON if dryrun was not set!  I think this patch should fix it (someone 
who actually uses vnc & dryrun should test it, though).

  -George

+-------------------+----------------------------------------
| dunlapg@umich.edu | http://www-personal.umich.edu/~dunlapg 
+-------------------+----------------------------------------
|  Who could move a mountain, who could love their enemy?
|  Who could rejoice in pain, and turn the other cheek?
|	- Rich Mullins, "Surely God is With Us"
+------------------------------------------------------------
| Outlaw Junk Email! Support HR 1748 (www.cauce.org)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 23 Jun 2005, at 15:23, George Washington Dunlap III wrote:
> A patch that was applied yesterday tried to turn the vnc option off if 
> dryrun was set.  Unfortunately, the way it was actually coded turned 
> vnc ON if dryrun was not set!  I think this patch should fix it 
> (someone who actually uses vnc & dryrun should test it, though).
>
>  -George
That patch was originally from Arun Sharma at Intel. I''ve
cc''ed him.

  -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Keir Fraser wrote:
> On 23 Jun 2005, at 15:23, George Washington Dunlap III wrote:
> 
>> A patch that was applied yesterday tried to turn the vnc option off if 
>> dryrun was set.  Unfortunately, the way it was actually coded turned 
>> vnc ON if dryrun was not set!  I think this patch should fix it 
>> (someone who actually uses vnc & dryrun should test it, though).
>>
>>  -George
> 
> 
> That patch was originally from Arun Sharma at Intel. I''ve
cc''ed him.
Please apply this patch. It fixes two problems:

- vnc shouldn''t be turned on by default (I didn''t spot it
because I
usually have VNC on)

- If it''s a boolean, its stringified version seen by xend would be 
"True" or "False". An integer is easier to parse in xend. A
patch that I
have in my queue expects it to be an integer.

	-Arun

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 23 Jun 2005, at 17:57, Arun Sharma wrote:
> Please apply this patch. It fixes two problems:
The patch is missing. :-)

  -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Keir Fraser wrote:
> 
> On 23 Jun 2005, at 17:57, Arun Sharma wrote:
> 
>> Please apply this patch. It fixes two problems:
> 
> 
> The patch is missing. :-)
I meant the patch George posted :)

	-Arun

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Arun Sharma wrote:
> Keir Fraser wrote:
> 
>>
>> On 23 Jun 2005, at 17:57, Arun Sharma wrote:
>>
>>> Please apply this patch. It fixes two problems:
>>
>>
>>
>> The patch is missing. :-)
> 
> 
> I meant the patch George posted :)
There''s a problem with that patch.

I think this patch is better. With George''s patch (and my original 
patch) xm create -n shows (vnc 0), even when vnc=1 in the config file.

	-Arun


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel