Nakajima, Jun
2005-Jun-18 23:48 UTC
RE: [Xen-devel] [patch] monitor_table is getting set to 0 for domux86_64
Scott Parish wrote:> On Sat, Jun 18, 2005 at 07:49:11PM +0000, Scott Parish wrote: > >> While the attached patch takes care of the problem, and i don''t >> understand everything i know about TF_kernel_mode and >> guest_table_user, so likely a better solution is in order. If >> somebody wouldn''t mind saying a few words about either of these, i''d >> appreciate it. > > I retract said patch--after understanding more of what i knew about > TF_kernel_mode, and looking into the syscall problem, it seems clear > that the problem is that TF_kernel_mode isn''t set. > > So now the question is, why is TF_kernel_mode is getting cleared by > arch_set_info_guest()? (or why isn''t VGCF_IN_KERNEL set?)I think you need to set VGCF_IN_KERNEL for x86_64 domains in xc_linux_build.c for initialization. For example, we are setting VGCF_VMX_GUEST in the builder (libxc/xc_vmx_build.c) like ctxt->flags = VGCF_VMX_GUEST;> > sRpJun --- Intel Open Source Technology Center _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Scott Parish
2005-Jun-19 00:10 UTC
[Xen-devel] [patch] clear ctxt->flags before getdomaininfo
On Sat, Jun 18, 2005 at 04:48:23PM -0700, Nakajima, Jun wrote:> I think you need to set VGCF_IN_KERNEL for x86_64 domains in > xc_linux_build.c for initialization. > > For example, we are setting VGCF_VMX_GUEST in the builder > (libxc/xc_vmx_build.c) like > ctxt->flags = VGCF_VMX_GUEST;I like the attached patch a little better, but if i''m mistaken about how getdomaininfo is suppose to work, then yes, what you''re suggesting is the right thing to do. Also attached is fixes for formatting nits. sRp -- Scott Parish Signed-off-by: srparish@us.ibm.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel