Nakajima, Jun
2005-Jun-08 23:29 UTC
RE: [Xen-devel] [patch] nx bit shouldn''t get set when disabled
Scott Parish wrote:> On Wed, Jun 08, 2005 at 03:47:01PM -0700, Nakajima, Jun wrote: > >> Agree on that part. Should read like: >> >> pte = pte_offset_kernel(pmd, (vstart + (i*PAGE_SIZE))); >> + pte->pte &= __supported_pte_mask; >> pfn = pte->pte >> PAGE_SHIFT; > > I dissent. Same reason as yesterday: the above might work right now, > but as soon as we enable NX the NX bit will end up in the pfn/mfn. > > sRpYour are correct. We always need to cut off the NX bit because that''s what HYPERVISOR_dom_mem_op expects. Jun --- Intel Open Source Technology Center _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel