Ian Pratt
2005-May-16 20:09 UTC
RE: [Xen-devel] possible changes was Re: [PATCH] make domu_debug run-time option + fix int3 handling for MP
> I can chunk this into 3 or 4 patches and make enabling > domu_debug a separate DOM0 operation. Would this be more palatable?Why do we need a new domain flag for this? What behaviour does the flag modify? Apologies if I''ve missed some earlier discussion. Thanks, Ian _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2005-May-16 20:17 UTC
Re: [Xen-devel] possible changes was Re: [PATCH] make domu_debug run-time option + fix int3 handling for MP
On 16 May 2005, at 21:18, Kip Macy wrote:> This is a continuation of the discussion that we had when the initial > debug > support went in. At the time Christian and you thought that it would > be ideal if > domu_debug were a domain-build / run-time option, as opposed to a xen > compile-time option. For the sake of expediency I didn''t do it at the > time. This > patch was intended to rectify that. > > Having it perpetually as a compile-time option seems like making a > ptrace a > compile-time option in Linux that defaulted to off.If we deal with the int3 demux problem then I''m happy to make ''domu_debug'' always on. Making it a per-domain config build-time option is not the tasteful solution imo. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Kip Macy
2005-May-16 20:18 UTC
RE: [Xen-devel] possible changes was Re: [PATCH] make domu_debug run-time option + fix int3 handling for MP
On Mon, 16 May 2005, Ian Pratt wrote:> > > I can chunk this into 3 or 4 patches and make enabling > > domu_debug a separate DOM0 operation. Would this be more palatable? > > Why do we need a new domain flag for this? > > What behaviour does the flag modify? > > Apologies if I''ve missed some earlier discussion. >This is a continuation of the discussion that we had when the initial debug support went in. At the time Christian and you thought that it would be ideal if domu_debug were a domain-build / run-time option, as opposed to a xen compile-time option. For the sake of expediency I didn''t do it at the time. This patch was intended to rectify that. Having it perpetually as a compile-time option seems like making a ptrace a compile-time option in Linux that defaulted to off. -Kip _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Kip Macy
2005-May-16 20:29 UTC
RE: [Xen-devel] possible changes was Re: [PATCH] make domu_debug run-time option + fix int3 handling for MP
> > Why do we need a new domain flag for this?This is equivalent to the per-process flag that is set in UN*X to indicate that a process is being ptraced. -Kip _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel