Xen devel - May 2005 - [PATCH] Increase size of sxpr parser input buffer

Increase the size of the sxpr parser input buffer from 1024 characters, which
isn''t long enough to hold larger domain configurations (xfrd transmits
the
entire domain config sxpr as a single atom inside of another sxpr).

Signed-off-by: Jody Belka <knew (dash) xen (at) pimb (dot) org>

diff -durN xen.orig/tools/libxutil/sxpr_parser.h
xen.new/tools/libxutil/sxpr_parser.h
--- xen.orig/tools/libxutil/sxpr_parser.h	2005-05-05 21:31:52.000000000 +0200
+++ xen.new/tools/libxutil/sxpr_parser.h	2005-05-07 18:55:30.203005432 +0200
@@ -28,7 +28,7 @@
 /** Size of a parser input buffer.
  * Tokens read must fit into this size (including trailing null).
  */
-#define PARSER_BUF_SIZE 1024
+#define PARSER_BUF_SIZE 4096
 
 struct Parser;
 typedef int ParserStateFn(struct Parser *, char c);

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Sat, 2005-05-07 at 19:11 +0200, Jody Belka wrote:
> plain text document attachment (sxpr_parser.patch)
> Increase the size of the sxpr parser input buffer from 1024 characters,
which
> isn''t long enough to hold larger domain configurations (xfrd
transmits the
> entire domain config sxpr as a single atom inside of another sxpr).
This seems like the wrong fix. The buffer size wasn''t the problem. The
problem was the bad design assumption in xfrd.

It''s almost always the wrong thing to insert a patch whose effect is to
mask a known problem.

shap


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel