Scott Parish
2005-May-04 23:06 UTC
[Xen-devel] [patch] explicitly defining memmove for x86_64
Without the attached patch ubuntu''s gcc (3.3.5) was complaining about the implicit declaration of __builtin_memmove. Extern''ing past that, the linker wouldn''t resolve the same symbol. This patch just does the same thing that is already done for x86_32. signed-off-by: scott parish <srparish@us.ibm.com> sRp -- Scott Parish _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
David F Barrera
2005-May-05 15:04 UTC
Re: [Xen-devel] [patch] explicitly defining memmove for x86_64
I applied this patch, and it went further, but it is failing now with
these errors:
gcc -DPIC -m64 -Wall -Werror -O3 -fno-strict-aliasing -
I ../../tools/libxutil
-I. -Wp,-MD,.xc_ptrace.opic.d -fPIC -c -o xc_ptrace.opic xc_ptrace.c
In file included from /usr/include/asm/sigcontext.h:4,
from /usr/include/asm-x86_64/processor.h:13,
from /usr/include/asm/processor.h:4,
from /usr/include/asm-x86_64/elf.h:10,
from /usr/include/asm/elf.h:4,
from xc_ptrace.c:4:
/usr/include/asm-x86_64/sigcontext.h:9: error: redefinition of `struct
_fpstate''
/usr/include/asm-x86_64/sigcontext.h:23: error: redefinition of `struct
sigconte
xt''
In file included from /usr/include/asm/pda.h:4,
from /usr/include/asm-x86_64/current.h:7,
from /usr/include/asm/current.h:4,
from /usr/include/asm-x86_64/processor.h:18,
from /usr/include/asm/processor.h:4,
from /usr/include/asm-x86_64/elf.h:10,
from /usr/include/asm/elf.h:4,
from xc_ptrace.c:4:
/usr/include/asm-x86_64/pda.h:26: error: `CONFIG_X86_L1_CACHE_SHIFT''
undeclared
here (not in a function)
/usr/include/asm-x86_64/pda.h:26: error: requested alignment is not a
constant
In file included from /usr/include/asm/system.h:4,
from /usr/include/asm-x86_64/processor.h:19,
from /usr/include/asm/processor.h:4,
from /usr/include/asm-x86_64/elf.h:10,
from /usr/include/asm/elf.h:4,
from xc_ptrace.c:4:
/usr/include/asm-x86_64/system.h: In function `__cmpxchg'':
/usr/include/asm-x86_64/system.h:249: error: `LOCK_PREFIX'' undeclared
(first use
in this function)
/usr/include/asm-x86_64/system.h:249: error: (Each undeclared identifier
is repo
rted only once
/usr/include/asm-x86_64/system.h:249: error: for each function it
appears in.)
/usr/include/asm-x86_64/system.h:249: error: parse error before string
constant
/usr/include/asm-x86_64/system.h:255: error: parse error before string
constant
/usr/include/asm-x86_64/system.h:261: error: parse error before string
constant
/usr/include/asm-x86_64/system.h:267: error: parse error before string
constant
In file included from /usr/include/asm/processor.h:4,
from /usr/include/asm-x86_64/elf.h:10,
from /usr/include/asm/elf.h:4,
from xc_ptrace.c:4:
/usr/include/asm-x86_64/processor.h: At top level:
/usr/include/asm-x86_64/processor.h:229: error:
`CONFIG_X86_L1_CACHE_SHIFT'' unde clared here (not in a
function)
/usr/include/asm-x86_64/processor.h:229: error: requested alignment is
not a con stant
/usr/include/asm-x86_64/processor.h: In function `prefetchw'':
/usr/include/asm-x86_64/processor.h:396: error: called object is not a
function
make[4]: *** [xc_ptrace.opic] Error 1
make[4]: Leaving directory `/tmp/xen-unstable/tools/libxc''
make[3]: *** [build] Error 2
make[3]: Leaving directory `/tmp/xen-unstable/tools/libxc''
make[2]: *** [install] Error 2
make[2]: Leaving directory `/tmp/xen-unstable/tools''
make[1]: *** [tools] Error 2
make[1]: Leaving directory `/tmp/xen-unstable''
make: *** [world] Error 2
bl2-14:/tmp/xen-unstable #
On Wed, 2005-05-04 at 23:06 +0000, Scott Parish wrote:> Without the attached patch ubuntu''s gcc (3.3.5) was complaining
about
> the implicit declaration of __builtin_memmove. Extern''ing past
that,
> the linker wouldn''t resolve the same symbol.
>
> This patch just does the same thing that is already done for x86_32.
>
> signed-off-by: scott parish <srparish@us.ibm.com>
>
> sRp
>
> --
> Scott Parish
> _______________________________________________ Xen-devel mailing list
Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Rich Persaud
2005-May-05 15:49 UTC
Re: [Xen-devel] [patch] explicitly defining memmove for x86_64
-----Original Message-----
From: "Rich Persaud" <rich@xensource.com>
Date: Thu, 5 May 2005 15:31:09
To:xen-devel-bounces@lists.xensource.com
Subject: Re: [Xen-devel] [patch] explicitly defining memmove for x86_64
Temporary workaround: comment out xc-ptrace.c in tools/libxc/Makefile.
Rich
-----Original Message-----
From: David F Barrera <dfbp@us.ibm.com>
Date: Thu, 05 May 2005 10:04:33
To:xen-devel@lists.xensource.com
Subject: Re: [Xen-devel] [patch] explicitly defining memmove for x86_64
I applied this patch, and it went further, but it is failing now with
these errors:
gcc -DPIC -m64 -Wall -Werror -O3 -fno-strict-aliasing -
I ../../tools/libxutil
-I. -Wp,-MD,.xc_ptrace.opic.d -fPIC -c -o xc_ptrace.opic xc_ptrace.c
In file included from /usr/include/asm/sigcontext.h:4,
from /usr/include/asm-x86_64/processor.h:13,
from /usr/include/asm/processor.h:4,
from /usr/include/asm-x86_64/elf.h:10,
from /usr/include/asm/elf.h:4,
from xc_ptrace.c:4:
/usr/include/asm-x86_64/sigcontext.h:9: error: redefinition of `struct
_fpstate''
/usr/include/asm-x86_64/sigcontext.h:23: error: redefinition of `struct
sigconte
xt''
In file included from /usr/include/asm/pda.h:4,
from /usr/include/asm-x86_64/current.h:7,
from /usr/include/asm/current.h:4,
from /usr/include/asm-x86_64/processor.h:18,
from /usr/include/asm/processor.h:4,
from /usr/include/asm-x86_64/elf.h:10,
from /usr/include/asm/elf.h:4,
from xc_ptrace.c:4:
/usr/include/asm-x86_64/pda.h:26: error: `CONFIG_X86_L1_CACHE_SHIFT''
undeclared
here (not in a function)
/usr/include/asm-x86_64/pda.h:26: error: requested alignment is not a
constant
In file included from /usr/include/asm/system.h:4,
from /usr/include/asm-x86_64/processor.h:19,
from /usr/include/asm/processor.h:4,
from /usr/include/asm-x86_64/elf.h:10,
from /usr/include/asm/elf.h:4,
from xc_ptrace.c:4:
/usr/include/asm-x86_64/system.h: In function `__cmpxchg'':
/usr/include/asm-x86_64/system.h:249: error: `LOCK_PREFIX'' undeclared
(first use
in this function)
/usr/include/asm-x86_64/system.h:249: error: (Each undeclared identifier
is repo
rted only once
/usr/include/asm-x86_64/system.h:249: error: for each function it
appears in.)
/usr/include/asm-x86_64/system.h:249: error: parse error before string
constant
/usr/include/asm-x86_64/system.h:255: error: parse error before string
constant
/usr/include/asm-x86_64/system.h:261: error: parse error before string
constant
/usr/include/asm-x86_64/system.h:267: error: parse error before string
constant
In file included from /usr/include/asm/processor.h:4,
from /usr/include/asm-x86_64/elf.h:10,
from /usr/include/asm/elf.h:4,
from xc_ptrace.c:4:
/usr/include/asm-x86_64/processor.h: At top level:
/usr/include/asm-x86_64/processor.h:229: error:
`CONFIG_X86_L1_CACHE_SHIFT'' unde clared here (not in a
function)
/usr/include/asm-x86_64/processor.h:229: error: requested alignment is
not a con stant
/usr/include/asm-x86_64/processor.h: In function `prefetchw'':
/usr/include/asm-x86_64/processor.h:396: error: called object is not a
function
make[4]: *** [xc_ptrace.opic] Error 1
make[4]: Leaving directory `/tmp/xen-unstable/tools/libxc''
make[3]: *** [build] Error 2
make[3]: Leaving directory `/tmp/xen-unstable/tools/libxc''
make[2]: *** [install] Error 2
make[2]: Leaving directory `/tmp/xen-unstable/tools''
make[1]: *** [tools] Error 2
make[1]: Leaving directory `/tmp/xen-unstable''
make: *** [world] Error 2
bl2-14:/tmp/xen-unstable #
On Wed, 2005-05-04 at 23:06 +0000, Scott Parish wrote:> Without the attached patch ubuntu''s gcc (3.3.5) was complaining
about
> the implicit declaration of __builtin_memmove. Extern''ing past
that,
> the linker wouldn''t resolve the same symbol.
>
> This patch just does the same thing that is already done for x86_32.
>
> signed-off-by: scott parish <srparish@us.ibm.com>
>
> sRp
>
> --
> Scott Parish
> _______________________________________________ Xen-devel mailing list
Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
David F Barrera
2005-May-05 17:32 UTC
Re: [Xen-devel] [patch] explicitly defining memmove for x86_64
I had to comment out xc_ptrace_core.c in tools/libxc/Makefile as well. Thanks for the tip. David On Thu, 2005-05-05 at 15:49 +0000, Rich Persaud wrote:> -----Original Message----- > From: "Rich Persaud" <rich@xensource.com> > Date: Thu, 5 May 2005 15:31:09 > To:xen-devel-bounces@lists.xensource.com > Subject: Re: [Xen-devel] [patch] explicitly defining memmove for x86_64 > > Temporary workaround: comment out xc-ptrace.c in tools/libxc/Makefile. > > Rich > > -----Original Message----- > From: David F Barrera <dfbp@us.ibm.com> > Date: Thu, 05 May 2005 10:04:33 > To:xen-devel@lists.xensource.com > Subject: Re: [Xen-devel] [patch] explicitly defining memmove for x86_64 > > I applied this patch, and it went further, but it is failing now with > these errors: > > gcc -DPIC -m64 -Wall -Werror -O3 -fno-strict-aliasing - > I ../../tools/libxutil > -I. -Wp,-MD,.xc_ptrace.opic.d -fPIC -c -o xc_ptrace.opic xc_ptrace.c > In file included from /usr/include/asm/sigcontext.h:4, > from /usr/include/asm-x86_64/processor.h:13, > from /usr/include/asm/processor.h:4, > from /usr/include/asm-x86_64/elf.h:10, > from /usr/include/asm/elf.h:4, > from xc_ptrace.c:4: > /usr/include/asm-x86_64/sigcontext.h:9: error: redefinition of `struct > _fpstate'' > /usr/include/asm-x86_64/sigcontext.h:23: error: redefinition of `struct > sigconte > xt'' > In file included from /usr/include/asm/pda.h:4, > from /usr/include/asm-x86_64/current.h:7, > from /usr/include/asm/current.h:4, > from /usr/include/asm-x86_64/processor.h:18, > from /usr/include/asm/processor.h:4, > from /usr/include/asm-x86_64/elf.h:10, > from /usr/include/asm/elf.h:4, > from xc_ptrace.c:4: > /usr/include/asm-x86_64/pda.h:26: error: `CONFIG_X86_L1_CACHE_SHIFT'' > undeclared > here (not in a function) > /usr/include/asm-x86_64/pda.h:26: error: requested alignment is not a > constant > In file included from /usr/include/asm/system.h:4, > from /usr/include/asm-x86_64/processor.h:19, > from /usr/include/asm/processor.h:4, > from /usr/include/asm-x86_64/elf.h:10, > from /usr/include/asm/elf.h:4, > from xc_ptrace.c:4: > /usr/include/asm-x86_64/system.h: In function `__cmpxchg'': > /usr/include/asm-x86_64/system.h:249: error: `LOCK_PREFIX'' undeclared > (first use > in this function) > /usr/include/asm-x86_64/system.h:249: error: (Each undeclared identifier > is repo > rted only once > /usr/include/asm-x86_64/system.h:249: error: for each function it > appears in.) > /usr/include/asm-x86_64/system.h:249: error: parse error before string > constant > /usr/include/asm-x86_64/system.h:255: error: parse error before string > constant > /usr/include/asm-x86_64/system.h:261: error: parse error before string > constant > /usr/include/asm-x86_64/system.h:267: error: parse error before string > constant > In file included from /usr/include/asm/processor.h:4, > from /usr/include/asm-x86_64/elf.h:10, > from /usr/include/asm/elf.h:4, > from xc_ptrace.c:4: > /usr/include/asm-x86_64/processor.h: At top level: > /usr/include/asm-x86_64/processor.h:229: error: > `CONFIG_X86_L1_CACHE_SHIFT'' unde clared here (not in a > function) > /usr/include/asm-x86_64/processor.h:229: error: requested alignment is > not a con stant > /usr/include/asm-x86_64/processor.h: In function `prefetchw'': > /usr/include/asm-x86_64/processor.h:396: error: called object is not a > function > make[4]: *** [xc_ptrace.opic] Error 1 > make[4]: Leaving directory `/tmp/xen-unstable/tools/libxc'' > make[3]: *** [build] Error 2 > make[3]: Leaving directory `/tmp/xen-unstable/tools/libxc'' > make[2]: *** [install] Error 2 > make[2]: Leaving directory `/tmp/xen-unstable/tools'' > make[1]: *** [tools] Error 2 > make[1]: Leaving directory `/tmp/xen-unstable'' > make: *** [world] Error 2 > bl2-14:/tmp/xen-unstable # > > > On Wed, 2005-05-04 at 23:06 +0000, Scott Parish wrote: > > Without the attached patch ubuntu''s gcc (3.3.5) was complaining about > > the implicit declaration of __builtin_memmove. Extern''ing past that, > > the linker wouldn''t resolve the same symbol. > > > > This patch just does the same thing that is already done for x86_32. > > > > signed-off-by: scott parish <srparish@us.ibm.com> > > > > sRp > > > > -- > > Scott Parish > > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
David F Barrera
2005-May-05 19:09 UTC
Re: [Xen-devel] [patch] explicitly defining memmove for x86_64
OK, I got a lot further this time. However, now I am getting an error indicating that file arch/xen/x86_64/pci/direct.c is missing. Indeed, xen-unstable/linux-2.6.11-xen0/arch/xen/x86_64/pci/direct.c is a link to ../xen-unstable/linux-2.6.11-xen0/arch/xen/i386/pci/direct.c, which does not exist. Here''s the error: CC arch/xen/x86_64/pci/common.o CC arch/xen/x86_64/pci/direct.o gcc: arch/xen/x86_64/pci/direct.c: No such file or directory gcc: no input files make[5]: *** [arch/xen/x86_64/pci/direct.o] Error 1 make[4]: *** [arch/xen/x86_64/pci] Error 2 make[4]: Leaving directory `/tmp/xen-unstable/linux-2.6.11-xen0'' make[3]: *** [build] Error 2 make[3]: Leaving directory `/tmp/xen-unstable'' make[2]: *** [linux-2.6-xen0-build] Error 2 make[2]: Leaving directory `/tmp/xen-unstable'' make[1]: *** [kernels] Error 1 make[1]: Leaving directory `/tmp/xen-unstable'' make: *** [world] Error 2 bl2-14:/tmp/xen-unstable # I''ve submitted [Bug 22] New: "x86_64 build fails: gcc: arch/xen/x86_64/pci/direct.c: No such file or directory" to document this problem. David On Thu, 2005-05-05 at 12:32 -0500, David F Barrera wrote:> I had to comment out xc_ptrace_core.c in tools/libxc/Makefile as well. > Thanks for the tip. > > David > > On Thu, 2005-05-05 at 15:49 +0000, Rich Persaud wrote: > > -----Original Message----- > > From: "Rich Persaud" <rich@xensource.com> > > Date: Thu, 5 May 2005 15:31:09 > > To:xen-devel-bounces@lists.xensource.com > > Subject: Re: [Xen-devel] [patch] explicitly defining memmove for x86_64 > > > > Temporary workaround: comment out xc-ptrace.c in tools/libxc/Makefile. > > > > Rich > > > > -----Original Message----- > > From: David F Barrera <dfbp@us.ibm.com> > > Date: Thu, 05 May 2005 10:04:33 > > To:xen-devel@lists.xensource.com > > Subject: Re: [Xen-devel] [patch] explicitly defining memmove for x86_64 > > > > I applied this patch, and it went further, but it is failing now with > > these errors: > > > > gcc -DPIC -m64 -Wall -Werror -O3 -fno-strict-aliasing - > > I ../../tools/libxutil > > -I. -Wp,-MD,.xc_ptrace.opic.d -fPIC -c -o xc_ptrace.opic xc_ptrace.c > > In file included from /usr/include/asm/sigcontext.h:4, > > from /usr/include/asm-x86_64/processor.h:13, > > from /usr/include/asm/processor.h:4, > > from /usr/include/asm-x86_64/elf.h:10, > > from /usr/include/asm/elf.h:4, > > from xc_ptrace.c:4: > > /usr/include/asm-x86_64/sigcontext.h:9: error: redefinition of `struct > > _fpstate'' > > /usr/include/asm-x86_64/sigcontext.h:23: error: redefinition of `struct > > sigconte > > xt'' > > In file included from /usr/include/asm/pda.h:4, > > from /usr/include/asm-x86_64/current.h:7, > > from /usr/include/asm/current.h:4, > > from /usr/include/asm-x86_64/processor.h:18, > > from /usr/include/asm/processor.h:4, > > from /usr/include/asm-x86_64/elf.h:10, > > from /usr/include/asm/elf.h:4, > > from xc_ptrace.c:4: > > /usr/include/asm-x86_64/pda.h:26: error: `CONFIG_X86_L1_CACHE_SHIFT'' > > undeclared > > here (not in a function) > > /usr/include/asm-x86_64/pda.h:26: error: requested alignment is not a > > constant > > In file included from /usr/include/asm/system.h:4, > > from /usr/include/asm-x86_64/processor.h:19, > > from /usr/include/asm/processor.h:4, > > from /usr/include/asm-x86_64/elf.h:10, > > from /usr/include/asm/elf.h:4, > > from xc_ptrace.c:4: > > /usr/include/asm-x86_64/system.h: In function `__cmpxchg'': > > /usr/include/asm-x86_64/system.h:249: error: `LOCK_PREFIX'' undeclared > > (first use > > in this function) > > /usr/include/asm-x86_64/system.h:249: error: (Each undeclared identifier > > is repo > > rted only once > > /usr/include/asm-x86_64/system.h:249: error: for each function it > > appears in.) > > /usr/include/asm-x86_64/system.h:249: error: parse error before string > > constant > > /usr/include/asm-x86_64/system.h:255: error: parse error before string > > constant > > /usr/include/asm-x86_64/system.h:261: error: parse error before string > > constant > > /usr/include/asm-x86_64/system.h:267: error: parse error before string > > constant > > In file included from /usr/include/asm/processor.h:4, > > from /usr/include/asm-x86_64/elf.h:10, > > from /usr/include/asm/elf.h:4, > > from xc_ptrace.c:4: > > /usr/include/asm-x86_64/processor.h: At top level: > > /usr/include/asm-x86_64/processor.h:229: error: > > `CONFIG_X86_L1_CACHE_SHIFT'' unde clared here (not in a > > function) > > /usr/include/asm-x86_64/processor.h:229: error: requested alignment is > > not a con stant > > /usr/include/asm-x86_64/processor.h: In function `prefetchw'': > > /usr/include/asm-x86_64/processor.h:396: error: called object is not a > > function > > make[4]: *** [xc_ptrace.opic] Error 1 > > make[4]: Leaving directory `/tmp/xen-unstable/tools/libxc'' > > make[3]: *** [build] Error 2 > > make[3]: Leaving directory `/tmp/xen-unstable/tools/libxc'' > > make[2]: *** [install] Error 2 > > make[2]: Leaving directory `/tmp/xen-unstable/tools'' > > make[1]: *** [tools] Error 2 > > make[1]: Leaving directory `/tmp/xen-unstable'' > > make: *** [world] Error 2 > > bl2-14:/tmp/xen-unstable # > > > > > > On Wed, 2005-05-04 at 23:06 +0000, Scott Parish wrote: > > > Without the attached patch ubuntu''s gcc (3.3.5) was complaining about > > > the implicit declaration of __builtin_memmove. Extern''ing past that, > > > the linker wouldn''t resolve the same symbol. > > > > > > This patch just does the same thing that is already done for x86_32. > > > > > > signed-off-by: scott parish <srparish@us.ibm.com> > > > > > > sRp > > > > > > -- > > > Scott Parish > > > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel > > > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xensource.com > > http://lists.xensource.com/xen-devel > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xensource.com > > http://lists.xensource.com/xen-devel > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Kip Macy
2005-May-05 19:32 UTC
Re: [Xen-devel] [patch] explicitly defining memmove for x86_64
I''ll consolidate the two of them into one file and then put an ifdef around it. The question is, what should the ifdef be? -Kip On Thu, 5 May 2005, David F Barrera wrote:> I had to comment out xc_ptrace_core.c in tools/libxc/Makefile as well. > Thanks for the tip. > > David > > On Thu, 2005-05-05 at 15:49 +0000, Rich Persaud wrote: > > -----Original Message----- > > From: "Rich Persaud" <rich@xensource.com> > > Date: Thu, 5 May 2005 15:31:09 > > To:xen-devel-bounces@lists.xensource.com > > Subject: Re: [Xen-devel] [patch] explicitly defining memmove for x86_64 > > > > Temporary workaround: comment out xc-ptrace.c in tools/libxc/Makefile. > > > > Rich > > > > -----Original Message----- > > From: David F Barrera <dfbp@us.ibm.com> > > Date: Thu, 05 May 2005 10:04:33 > > To:xen-devel@lists.xensource.com > > Subject: Re: [Xen-devel] [patch] explicitly defining memmove for x86_64 > > > > I applied this patch, and it went further, but it is failing now with > > these errors: > > > > gcc -DPIC -m64 -Wall -Werror -O3 -fno-strict-aliasing - > > I ../../tools/libxutil > > -I. -Wp,-MD,.xc_ptrace.opic.d -fPIC -c -o xc_ptrace.opic xc_ptrace.c > > In file included from /usr/include/asm/sigcontext.h:4, > > from /usr/include/asm-x86_64/processor.h:13, > > from /usr/include/asm/processor.h:4, > > from /usr/include/asm-x86_64/elf.h:10, > > from /usr/include/asm/elf.h:4, > > from xc_ptrace.c:4: > > /usr/include/asm-x86_64/sigcontext.h:9: error: redefinition of `struct > > _fpstate'' > > /usr/include/asm-x86_64/sigcontext.h:23: error: redefinition of `struct > > sigconte > > xt'' > > In file included from /usr/include/asm/pda.h:4, > > from /usr/include/asm-x86_64/current.h:7, > > from /usr/include/asm/current.h:4, > > from /usr/include/asm-x86_64/processor.h:18, > > from /usr/include/asm/processor.h:4, > > from /usr/include/asm-x86_64/elf.h:10, > > from /usr/include/asm/elf.h:4, > > from xc_ptrace.c:4: > > /usr/include/asm-x86_64/pda.h:26: error: `CONFIG_X86_L1_CACHE_SHIFT'' > > undeclared > > here (not in a function) > > /usr/include/asm-x86_64/pda.h:26: error: requested alignment is not a > > constant > > In file included from /usr/include/asm/system.h:4, > > from /usr/include/asm-x86_64/processor.h:19, > > from /usr/include/asm/processor.h:4, > > from /usr/include/asm-x86_64/elf.h:10, > > from /usr/include/asm/elf.h:4, > > from xc_ptrace.c:4: > > /usr/include/asm-x86_64/system.h: In function `__cmpxchg'': > > /usr/include/asm-x86_64/system.h:249: error: `LOCK_PREFIX'' undeclared > > (first use > > in this function) > > /usr/include/asm-x86_64/system.h:249: error: (Each undeclared identifier > > is repo > > rted only once > > /usr/include/asm-x86_64/system.h:249: error: for each function it > > appears in.) > > /usr/include/asm-x86_64/system.h:249: error: parse error before string > > constant > > /usr/include/asm-x86_64/system.h:255: error: parse error before string > > constant > > /usr/include/asm-x86_64/system.h:261: error: parse error before string > > constant > > /usr/include/asm-x86_64/system.h:267: error: parse error before string > > constant > > In file included from /usr/include/asm/processor.h:4, > > from /usr/include/asm-x86_64/elf.h:10, > > from /usr/include/asm/elf.h:4, > > from xc_ptrace.c:4: > > /usr/include/asm-x86_64/processor.h: At top level: > > /usr/include/asm-x86_64/processor.h:229: error: > > `CONFIG_X86_L1_CACHE_SHIFT'' unde clared here (not in a > > function) > > /usr/include/asm-x86_64/processor.h:229: error: requested alignment is > > not a con stant > > /usr/include/asm-x86_64/processor.h: In function `prefetchw'': > > /usr/include/asm-x86_64/processor.h:396: error: called object is not a > > function > > make[4]: *** [xc_ptrace.opic] Error 1 > > make[4]: Leaving directory `/tmp/xen-unstable/tools/libxc'' > > make[3]: *** [build] Error 2 > > make[3]: Leaving directory `/tmp/xen-unstable/tools/libxc'' > > make[2]: *** [install] Error 2 > > make[2]: Leaving directory `/tmp/xen-unstable/tools'' > > make[1]: *** [tools] Error 2 > > make[1]: Leaving directory `/tmp/xen-unstable'' > > make: *** [world] Error 2 > > bl2-14:/tmp/xen-unstable # > > > > > > On Wed, 2005-05-04 at 23:06 +0000, Scott Parish wrote: > > > Without the attached patch ubuntu''s gcc (3.3.5) was complaining about > > > the implicit declaration of __builtin_memmove. Extern''ing past that, > > > the linker wouldn''t resolve the same symbol. > > > > > > This patch just does the same thing that is already done for x86_32. > > > > > > signed-off-by: scott parish <srparish@us.ibm.com> > > > > > > sRp > > > > > > -- > > > Scott Parish > > > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel > > > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xensource.com > > http://lists.xensource.com/xen-devel > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xensource.com > > http://lists.xensource.com/xen-devel > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >-- "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." - Brian W. Kernighan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2005-May-07 10:13 UTC
Re: [Xen-devel] [patch] explicitly defining memmove for x86_64
> Without the attached patch ubuntu''s gcc (3.3.5) was complaining about > the implicit declaration of __builtin_memmove. Extern''ing past that, > the linker wouldn''t resolve the same symbol. > > This patch just does the same thing that is already done for x86_32. > > signed-off-by: scott parish <srparish@us.ibm.com> > > sRpThanks. I checked in a version that always uses the implementation in arch/x86/string.c. It''s not worthwhile inlining since it''s never used anywhere performance critical (should probably remove the version in x86_32/string.h as well). -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel