Hey I?m cleaning up some code at my work place, and it turns out someone had forked Search::Xapian and added MatchSpy bindings for it for one of our internal projects. I was wondering if I should try to extract this as a patch against the current Search::Xapian code, and submit it, or if that is not wanted/wasted effort? It seems to be against 1.2.4.n of Search::Xapian, but I think I should be able to update it against the most current release. Last time I was involved (which was a long time ago, haha), the Search::Xapian stuff was moving to SWIG soon, but I am not sure if that has happened or not yet? If I want to create a patch, should it be against the xapian-bindings directory/repo? or somewhere else? Thanks, Andreas
On Wed, Aug 19, 2015 at 05:31:31PM +0700, Andreas Marienborg wrote:> I?m cleaning up some code at my work place, and it turns out someone > had forked Search::Xapian and added MatchSpy bindings for it for one > of our internal projects. I was wondering if I should try to extract > this as a patch against the current Search::Xapian code, and submit > it, or if that is not wanted/wasted effort? It seems to be against > 1.2.4.n of Search::Xapian, but I think I should be able to update it > against the most current release. > > Last time I was involved (which was a long time ago, haha), the > Search::Xapian stuff was moving to SWIG soon, but I am not sure if > that has happened or not yet?The 1.3.x development series only has SWIG-based Perl bindings. In 1.2.x, there are both the hand-coded XS ones and SWIG-based ones, but the XS ones are the ones most people use (well, probably - it's hard to actually measure). There's going to be a new 1.4.x stable release series fairly soon, but 1.2.x will live on for a while to give people a chance to transition. So a patch to add MatchSpy support to the XS bindings seems useful at this point.> If I want to create a patch, should it be against the xapian-bindings > directory/repo? or somewhere else?Against the search-xapian directory of the git repo would be best. The SWIG-based bindings should already wrap MatchSpy. Cheers, Olly
On 19 August 2015 at 20:55:32, Olly Betts (olly at survex.com) wrote: On Wed, Aug 19, 2015 at 05:31:31PM +0700, Andreas Marienborg wrote:> If I want to create a patch, should it be against the xapian-bindings > directory/repo? or somewhere else?Against the search-xapian directory of the git repo would be best. Hey, I made a branch from svn/1.2 on github, and tried to forward port? the changes to this branch. I managed to wrap the ValueCountMatchSpy, and write tests to ensure it is working. In the original code there was also some code for PerlMatchSpy, but I did not manage to get this working yet. My XS/C-skills are rather limited unfortunately. If someone with more XS-exerpience could take a look and provide some feedback, that would be great. I created a pull request[1]. I would like to get the PerlMatchSpy thing working as well, but it might be better to get the wrapping of the? ValueCountMatchSpy merged/released regardless of the PerlMatchSpy thing? Any and all feedback is much appreciated :) - a [1]: https://github.com/xapian/xapian/pull/73