Up until now, the PHP bindings have renamed variants of overloaded
methods (or in some cases only wrapped some variants). So for example
we have:
new_Query(STRING)
new_Query_from_query_pair(OP, QUERY, QUERY)
new_Query_from_term_pair(OP, STRING, STRING)
new_Query_empty()
And there's no wrapping of the C++ Query constructors which allow you
to pass a Query op plus a list of either terms or Query objects.
The reason for all this renaming was limitations in SWIG. These have
now been fixed, and I've started writing the typemaps required to wrap
these all as new_Query.
What I'd like feedback on is whether anyone will be upset to see the
old forms dropped right away. If we do this, it'll mean code will need
fixing to work on the next release, but the changes are very easy (just
change new_Query_* to new_Query, etc).
Cheers,
Olly
On Thu, Dec 15, 2005 at 11:56:38AM +0000, Olly Betts wrote:> What I'd like feedback on is whether anyone will be upset to see the > old forms dropped right away. If we do this, it'll mean code will need > fixing to work on the next release, but the changes are very easy (just > change new_Query_* to new_Query, etc).New one for 0.9.3, kill the old ones in whatever the release after that is (whether 0.9.4 or 1.0.0). By the way, could the front page of the website have a "latest release is" tag that points to the download page? Currently the download page (and SVN) is the only way of finding out the current version... J -- /--------------------------------------------------------------------------\ James Aylett xapian.org james@tartarus.org uncertaintydivision.org
Olly Betts wrote:> What I'd like feedback on is whether anyone will be upset to see the > old forms dropped right away. If we do this, it'll mean code will need > fixing to work on the next release, but the changes are very easy (just > change new_Query_* to new_Query, etc).sounds fine to me, but I haven't actually done anything with Xapian yet :-) Do you know if the new swig version might fix that crashing issue I mentioned earlier? (I think some destructor was getting called twice). I'd love to help out in improving the PHP bindings if I can, e.g. testing etc. Dave -- David Heath Freelance Software Developer david@davidheath.org http://davidheath.org/