> [Please keep discussions on the mailing list.]I accidentally clicked on "Reply" instead of "Reply to all" but later I did send a separate mail to the mailing list.> Thinking about this, the way that CGI works is you set a 'Status' > header which changes this behaviour. So we don't actually need a > new command, just something like: > > $httpheader{Status,302 Found} > $httpheader{Location,$cgi{URL}}Ok, got it. I was initially under the impression that we needed a new Omegascript command to enable opening a webpage given a url.> See http://www.oreilly.com/openbook/cgi/ch03_07.html and the > parse_omegascript() function (in query.cc).Thanks, I found that link very helpful. Great book on CGI programming.> You can run omega.cgi from the command line without installing it and > going via a web server. This is what the omegatests do, for instance.Yeah, I was thinking about doing the same. Thanks, will try that.> Don't do it like this; you can open a PR and note in the comment that > it isn't ready for merge, and then we get much better tools for > discussing the source code.Okay, will open a PR with adding the new $qid{} command first. Although, I was going to wait until the preprocessing script was complete and then open a single PR for the whole logging functionality. Thanks, Vivek -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xapian.org/pipermail/xapian-devel/attachments/20170618/8f7126b0/attachment.html>
On 18 Jun 2017, at 12:07, Vivek Pal <vivekpal.dtu at gmail.com> wrote:> I accidentally clicked on "Reply" instead of "Reply to all" but later I did > send a separate mail to the mailing list.It's frustrating how easy that is to do :(> > Don't do it like this; you can open a PR and note in the comment that > > it isn't ready for merge, and then we get much better tools for > > discussing the source code. > > Okay, will open a PR with adding the new $qid{} command first. Although, > I was going to wait until the preprocessing script was complete and then > open a single PR for the whole logging functionality.No, I'd open the smallest PR that makes sense. $qid{} allows people to build all sorts of click logging applications, and probably some others as well. The two templates and the processing script then take this in a particular direction, towards clickstream tools for LTR. (And then later PRs will address building the LTR input files, probably with documentation on how to use them to build a LTR model, and finally something covering how to use that model.) J -- James Aylett, occasional troublemaker & project governance xapian.org
> It's frustrating how easy that is to do :(Yes, indeed.> No, I'd open the smallest PR that makes sense. $qid{} allows > people to build all sorts of click logging applications, and probably > some others as well.I agree. I'll open a PR for the same today itself. Thanks, Vivek -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xapian.org/pipermail/xapian-devel/attachments/20170618/792c1618/attachment.html>