Hi all, I completely facilitated simple indexing with xapian_index function, and also developed a DatabaseWrapper. Only a few more modifications are remaining to completely facilitate simple search with xapian_search function. Best regards, Amanda -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xapian.org/pipermail/xapian-devel/attachments/20160612/354be079/attachment.html>
On Sun, Jun 12, 2016 at 12:18:54PM +0530, Amanda Jayanetti wrote:> I completely facilitated simple indexing with xapian_index function, and > also developed a DatabaseWrapper. Only a few more modifications are > remaining to completely facilitate simple search with xapian_search > function.Amanda -- that's great. I did ask you a while ago to start using pull requests into your own repo, so it's easier for mentors to work with you on the work you're doing. This will become increasingly important going forward as you're building on your earlier work, so please start doing this sooner rather than later as it tends to take a little bit of time to become comfortable with that way of working. For instance, I'd have been able to point out before you committed to master that all the files in man/ that you've added don't need to be in the repo, because they're automatically generated from other source code. (Having anything twice increases the chance it won't be in sync.) I don't know if you'll need to add any specific rules or help for running roxygen2, or if that's part of a normal R build process, but either way I'd get rid of the generated files so there's one "source of truth" in the codebase. J -- James Aylett, occasional trouble-maker xapian.org
> > >> I did ask you a while ago to start using pull requests into your own > >> repo, so it's easier for mentors to work with you on the work you're > >> doing.Will do so from now onwards.>> all the files in man/ that you've added don't need to be > >> in the repo, because they're automatically generated from other source > code. >Users can install RXapian package directly from github using the command 'install_github(?RXapian?)'. Once the package is installed, if automatically generated documentation(.Rd files) were included in the git repository, users can easily view all the information about the package, functions, parameters as well as examples by simply pressing f1 (in Rstudio). This is a very helpful feature which will not be available to users/evaluators of RXapian if those files were removed. So wouldn't it be better to include documentation files in git repo until RXapian is contributed to CRAN? Best regards, Amanda -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xapian.org/pipermail/xapian-devel/attachments/20160614/ad6d79e9/attachment.html>