Xapian devel - Oct 2013 - Patch for Modern Cygwin

Hello,

Please, change line #63 in
'<xapian-core-1.3.1>/backends/flint-lock.cc'
from:

     cygwin_conv_to_win32_path(filename.c_str(), fnm);

to:

     cygwin_conv_path(0, filename.c_str(), fnm, MAX_PATH);

since `cygwin_conv_to_win32_path` is now deprecated.
Or perhaps detect the version of Cygwin, and keep both variants to 
ensure backward compatibility.
I can confirm that after this change everything builds just fine.

Best regards,
Alexander Shukaev

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.xapian.org/pipermail/xapian-devel/attachments/20131019/2e4b8120/attachment.html>

On Sat, Oct 19, 2013 at 03:22:16AM +0200, Haroogan
wrote:
> Please, change line #63 in
> '<xapian-core-1.3.1>/backends/flint-lock.cc' from:
> 
>     cygwin_conv_to_win32_path(filename.c_str(), fnm);
> 
> to:
> 
>     cygwin_conv_path(0, filename.c_str(), fnm, MAX_PATH);
Reading the cygwin documentation, it looks to me like the first argument
should really be CCP_POSIX_TO_WIN_A|CCP_RELATIVE rather than 0, and we
should check the return value too.
> since `cygwin_conv_to_win32_path` is now deprecated.
> Or perhaps detect the version of Cygwin, and keep both variants to
> ensure backward compatibility.
I've committed a fix which does the above and this too, but I don't have
a cygwin setup so please test it and report how you get on:

http://trac.xapian.org/changeset/17580/svn

Cheers,
    Olly