Olly Betts
2008-Apr-23 03:13 UTC
[Xapian-devel] [Xapian-commits] 10367: trunk/xapian-bindings/ trunk/xapian-bindings/python/
On Wed, Apr 23, 2008 at 01:25:46AM +0100, richard wrote:> python/doxy2swig.py.in: Fix build with --enable-maintainer-mode > and python 2.2, by providing fallback for the "textwrap" module, > which isn't present by default in 2.2.It doesn't seem great that the files we ship should vary so greatly depending what Python version is installed. Perhaps it would be better just to say that --enable-maintainer-mode requires Python >= 2.3? Or just include a function to which implements textwrap.fill() and always use that. Or we could just drop 2.2 support in 1.1.0 - perhaps a slightly extreme reaction, but it's close to 5 years since the last Python 2.2 release, and I can't see people conservative enough to still use such an old Python version wanting to install a ".0" release of Xapian anyway, so it's worth considering. Cheers, Olly
James Aylett
2008-Apr-23 08:20 UTC
[Xapian-devel] [Xapian-commits] 10367: trunk/xapian-bindings/ trunk/xapian-bindings/python/
On Wed, Apr 23, 2008 at 04:13:22AM +0100, Olly Betts wrote:> > python/doxy2swig.py.in: Fix build with --enable-maintainer-mode > > and python 2.2, by providing fallback for the "textwrap" module, > > which isn't present by default in 2.2. > > It doesn't seem great that the files we ship should vary so greatly > depending what Python version is installed. Perhaps it would be better > just to say that --enable-maintainer-mode requires Python >= 2.3?+1> Or just include a function to which implements textwrap.fill() and > always use that.-1, too complex.> Or we could just drop 2.2 support in 1.1.0 - perhaps a slightly extreme > reaction, but it's close to 5 years since the last Python 2.2 release, > and I can't see people conservative enough to still use such an old > Python version wanting to install a ".0" release of Xapian anyway, so > it's worth considering.I'd rather deprecate 2.2 support at 1.1.0 and drop at 1.2.0, if we can. (We don't really have a policy for this, but it's in line with feature deprecation.) Not sure how we communicate it; python has some sort of deprecation warning system, I think, or we could just print a big banner on configuring xapian-bindings in some way? J -- /--------------------------------------------------------------------------\ James Aylett xapian.org james at tartarus.org uncertaintydivision.org