I got a warning from the list about the attachments being too big so I am not sure if the original went through. So here is a zip of the files. Sean On 8/30/05, Sean Long <sean.m.long@gmail.com> wrote:> I added all the event handlers for wxGrid. These patches also have > changes from my previous patches that have not been commited yet > (choicebook). wxGrid is actually getting useful now! > > Sean > > >_______________________________________________ wxruby-users mailing list wxruby-users@rubyforge.org http://rubyforge.org/mailman/listinfo/wxruby-users
Sean Long wrote:> I got a warning from the list about the attachments being too big so I > am not sure if the original went through.Sorry about that. The list had a max of 40k, which I have now bumped up to 120k. Anything above that goes to the list administrators (me and Curt, I think). I just hadn''t had a chance to "approve" it yet.> So here is a zip of the files.They didn''t apply cleanly, possibly because I applied some of your other patches before this one. Can you resend whatever isn''t already checked in? Thanks, Kevin
> They didn''t apply cleanly, possibly because I applied some of your other > patches before this one. Can you resend whatever isn''t already checked in?Here are the patches again. Sean -------------- next part -------------- A non-text attachment was scrubbed... Name: events_i.patch Type: application/octet-stream Size: 9726 bytes Desc: not available Url : http://rubyforge.org/pipermail/wxruby-users/attachments/20050901/af35209e/events_i-0001.obj -------------- next part -------------- A non-text attachment was scrubbed... Name: events_rb.patch Type: application/octet-stream Size: 6031 bytes Desc: not available Url : http://rubyforge.org/pipermail/wxruby-users/attachments/20050901/af35209e/events_rb-0001.obj -------------- next part -------------- A non-text attachment was scrubbed... Name: evthandler_i.patch Type: application/octet-stream Size: 10586 bytes Desc: not available Url : http://rubyforge.org/pipermail/wxruby-users/attachments/20050901/af35209e/evthandler_i-0001.obj
Sean Long wrote:>>They didn''t apply cleanly, possibly because I applied some of your other >>patches before this one. Can you resend whatever isn''t already checked in? > > > Here are the patches again.These applied cleanly, but it looks like pretty massive duplication of code between event.i and evthandler.i. I think all the methods should be defined only in evthandler. Can you confirm that? Or explain why we would have them in both places? I haven''t checked these in yet, pending your response. Thanks, Kevin
It should be Events.i in swig not Event.i in classes. I noticed Events.i is very similar to EvtHandler.i is there are reason for the duplication? I just do it that way because that is how it was done before. Sean On 9/3/05, Kevin Smith <wxruby@qualitycode.com> wrote:> Sean Long wrote: > >>They didn''t apply cleanly, possibly because I applied some of your other > >>patches before this one. Can you resend whatever isn''t already checked in? > > > > > > Here are the patches again. > > These applied cleanly, but it looks like pretty massive duplication of > code between event.i and evthandler.i. I think all the methods should be > defined only in evthandler. Can you confirm that? Or explain why we > would have them in both places? > > I haven''t checked these in yet, pending your response. > > Thanks, > > Kevin > _______________________________________________ > wxruby-users mailing list > wxruby-users@rubyforge.org > http://rubyforge.org/mailman/listinfo/wxruby-users >
Sean Long wrote:> It should be Events.i in swig not Event.i in classes. I noticed > Events.i is very similar to EvtHandler.i is there are reason for the > duplication? I just do it that way because that is how it was done > before.Ok. I have checked in the grid event stuff. I have added a note to TODO to eliminate the massive duplication. I think at some point someone decided to move it from one place to the other, but somehow forgot to do the delete part of the move after doing the copy. I can''t think of any reason we would want all that stuff in two places, and glancing at it I couldn''t see any need for it. Thanks, Kevin