wxruby development - Nov 2008 - Code and doc patch for ToolBar#add_item and Sizer#add_item

Hi all,

I''d really like to see this code and doc patch committed instead of
only the doc patch I submitted previously
(http://rubyforge.org/pipermail/wxruby-development/2008-November/001431.html).

Following my initial post
(http://rubyforge.org/pipermail/wxruby-development/2008-November/001426.html),
this new patch features :
- support of spacer in Sizer#add_item
- make bitmap the first and mandatory parameter in ToolBar#add_item
- corresponding documentation update

Cheers.

Chauk-Mean.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: toolbar_sizer_code_and_doc.patch
Type: text/x-patch
Size: 8913 bytes
Desc: not available
URL:
<http://rubyforge.org/pipermail/wxruby-development/attachments/20081111/29dadee8/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: toolbar_sizer_sample.rb
Type: application/x-ruby
Size: 1717 bytes
Desc: not available
URL:
<http://rubyforge.org/pipermail/wxruby-development/attachments/20081111/29dadee8/attachment-0001.bin>

Chauk-Mean P wrote:
> I''d really like to see this code and doc patch committed instead
of
> only the doc patch I submitted previously
>
(http://rubyforge.org/pipermail/wxruby-development/2008-November/001431.html).
>
> Following my initial post
>
(http://rubyforge.org/pipermail/wxruby-development/2008-November/001426.html),
> this new patch features :
> - support of spacer in Sizer#add_item
> - make bitmap the first and mandatory parameter in ToolBar#add_item
> - corresponding documentation update
Committed; thank you very much for these patches.

I put the sample in samples/etc. As a remark, ArtProvider has a 
get_bitmap class method so you don''t need to fetch an icon and manually
convert. I tweaked the sample to reflect this.

cheers
alex

Hi Alex,

2008/11/11 Alex Fenton <alex at pressure.to>:
> Chauk-Mean P wrote:
>>
>> I''d really like to see this code and doc patch committed
instead of
>> only the doc patch I submitted previously
>> this new patch features :
>> - support of spacer in Sizer#add_item
>> - make bitmap the first and mandatory parameter in ToolBar#add_item
>> - corresponding documentation update
>
> Committed; thank you very much for these patches.
That''s cool. Thanks.

Cheers.

Chauk-Mean.